Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the main settings on the guide #370

Closed
wants to merge 2 commits into from

Conversation

joji2468ng
Copy link
Member

@joji2468ng joji2468ng commented Dec 25, 2023

- Switched the component type name to the component name.

When classicChannelNames is off, it is using self.guide.compName in the enum list, which is the name of the type of the component, instead of the name of the component. I found it a bit confusing to see which section was which module.

armUI_L0_new

- Added a new param "Add Full Name Param" in the guide main settings.

The full name param won't appear on the host controller when it is turned off.
It's useful in case of no attributes/channels existing under the full name param like control_01 module.
*The option is turned on by default.

addFullName

@joji2468ng joji2468ng added the enhancement New feature or request label Dec 25, 2023
@joji2468ng joji2468ng self-assigned this Dec 25, 2023
@joji2468ng joji2468ng changed the title Updated the main settings Updated the main settings on the guide Dec 25, 2023
@miquelcampos
Copy link
Member

miquelcampos commented Jan 5, 2024

@joji2468ng The purpose is to share the same attrs when the names match, if we change that name and we share the UIHost of the same type, we will end up with 2 title names but the rest of the channels will be shared.
Also since it is only for the title it can be confusing when used with instance names for attr prefix
image
I am afraid I can't merge this PR. I am very sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 4.2.1
Development

Successfully merging this pull request may close these issues.

2 participants