Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_boot_pmtable design discussions #91

Open
3 of 4 tasks
barrettk opened this issue Feb 4, 2025 · 2 comments · May be fixed by #90
Open
3 of 4 tasks

make_boot_pmtable design discussions #91

barrettk opened this issue Feb 4, 2025 · 2 comments · May be fixed by #90
Labels
next release Issues/PRs to be included on the next release

Comments

@barrettk
Copy link
Contributor

barrettk commented Feb 4, 2025

A make_boot_pmtable function has been proposed here. It currently feels very similar to the existing make_pmtable, though there are a few questions (see below).

For reference, we are using the tables from the Expo as our guides to develop this function: https://merge.metrumrg.com/expo/expo1-nonmem-foce/posts/parameter-tables.html#create-bootstrap-parameter-table

  • Do we want the same . pmtype argument for controlling which parameter type is returned?

  • Can we confirm how we want bootstrap CI columns to be named? We have the current handling

    • Regular intervals would go from boot_ci_95 --> 95% CI when displayed (i.e. just displays relevant percentile).
    • There is also the special case where boot_ci_50 is renamed to IQR(rather than a percent).
  • Do we need any additional control that make_pmtable does not have?

  • As an aside, we wanted to check if we wanted a new footnote added to param_notes for displaying notes like the following:

  st_notes(glue("The confidence interval was determined from the 
                      2.5th and 97.5th percentiles of the non-parametric 
                      bootstrap (n={nrow(boot)}) estimates."))

The caveat is that we would have to provide both a .ci and N number of samples to create this.

@barrettk barrettk added the needs SME input SEM = Subject Matter Expert label Feb 4, 2025
@seth127
Copy link
Contributor

seth127 commented Feb 4, 2025

There was some discussion in #54 of updating make_pmtable() instead. I think we want to go with a separate function, as discussed here, but let's make sure that's the decision we want.

Either way, that issue can be closed when this one is.

@barrettk barrettk added the next release Issues/PRs to be included on the next release label Feb 5, 2025
@barrettk
Copy link
Contributor Author

barrettk commented Feb 6, 2025

Something to consider for the future is the idea of centering specific columns as part of make_boot_pmtable. We aren't doing this in make_pmtable currently, so both functions should likely get the same handling.

@barrettk barrettk removed the needs SME input SEM = Subject Matter Expert label Feb 7, 2025
@barrettk barrettk linked a pull request Feb 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Issues/PRs to be included on the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants