Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar suggestions for footnotes #82

Open
timwaterhouse opened this issue Dec 18, 2024 · 1 comment · May be fixed by #95
Open

Grammar suggestions for footnotes #82

timwaterhouse opened this issue Dec 18, 2024 · 1 comment · May be fixed by #95
Labels
next release Issues/PRs to be included on the next release

Comments

@timwaterhouse
Copy link

Can I please ask @KatherineKayMRG to weigh in on these suggestions for updates to param_notes()?

  • ci: change "intervals" to "interval"
  • cvOmegaEq: change "omegas" to "omega"
  • logTrans: change "log-domain" to "log domain"
  • logitTrans: change "logit-domain" to "logit domain"

(current list is here for reference)
@KatherineKayMRG
Copy link
Collaborator

@timwaterhouse I agree with all those updates. It would make them more consistent with other footnotes

@barrettk barrettk added the next release Issues/PRs to be included on the next release label Feb 6, 2025
barrettk added a commit that referenced this issue Feb 11, 2025
@barrettk
update grammar in param_notes
d2e8c63 
 - changes are consistent with those requested in #82
@barrettk barrettk linked a pull request Feb 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next release Issues/PRs to be included on the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Param notes grammar metrumresearchgroup/pmparams
3 participants
@barrettk @timwaterhouse @KatherineKayMRG