Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Expanded QNames #18

Conversation

david-waltermire
Copy link
Contributor

Committer Notes

This PR overhauls instance and definition naming to support expanded qnames. This is a precursor to adding support for namespace prefixes in Metapath and supporting multiple namespaces in the XML format binding.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@david-waltermire david-waltermire force-pushed the issue318-exapanded-qname-support branch from 71b2dfb to 075fa78 Compare April 16, 2024 01:53
@david-waltermire david-waltermire marked this pull request as draft April 16, 2024 18:11
@david-waltermire david-waltermire force-pushed the issue318-exapanded-qname-support branch 2 times, most recently from 8a5e852 to 11b49f9 Compare April 21, 2024 05:27
Copy link

coderabbitai bot commented Apr 21, 2024

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

155 files out of 210 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@david-waltermire david-waltermire force-pushed the issue318-exapanded-qname-support branch 3 times, most recently from 4859e15 to 0b40ec2 Compare April 21, 2024 05:49
@david-waltermire david-waltermire force-pushed the issue318-exapanded-qname-support branch 2 times, most recently from 726ea2b to 6c1aabd Compare April 21, 2024 06:01
@david-waltermire david-waltermire force-pushed the issue318-exapanded-qname-support branch from 6c1aabd to 22df472 Compare April 21, 2024 06:46
@david-waltermire
Copy link
Contributor Author

@coderabbitai review

@david-waltermire david-waltermire marked this pull request as ready for review April 21, 2024 07:02
@david-waltermire
Copy link
Contributor Author

@coderabbitai review

@david-waltermire david-waltermire merged commit c8ef0d7 into metaschema-framework:develop Apr 23, 2024
1 check passed
@david-waltermire david-waltermire deleted the issue318-exapanded-qname-support branch April 23, 2024 02:08
david-waltermire added a commit that referenced this pull request May 26, 2024
* Completed qualified name refacotring. JUnit tests are now running clean.
* Updated spotbugs to use the most recent version. Fixed a bunch of spotbugs issues.
* Refactored model path handling in Metapath parsing to use proper namespacing.
* adjusted codereview settings.
david-waltermire added a commit that referenced this pull request May 28, 2024
* Completed qualified name refacotring. JUnit tests are now running clean.
* Updated spotbugs to use the most recent version. Fixed a bunch of spotbugs issues.
* Refactored model path handling in Metapath parsing to use proper namespacing.
* adjusted codereview settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant