Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter argument conversion from flag node items to atomic values broken #323

Closed
aj-stein-gsa opened this issue Dec 31, 2024 · 0 comments · Fixed by #321 or #332
Closed

Parameter argument conversion from flag node items to atomic values broken #323

aj-stein-gsa opened this issue Dec 31, 2024 · 0 comments · Fixed by #321 or #332
Assignees
@aj-stein-gsa
Labels
bug Something isn't working java Pull requests that update Java code
Milestone
v2.2.0

Comments

@aj-stein-gsa
Copy link
Contributor

Describe the bug

Currently, when using a recent version of this library built on develop (as of 113e57b), evaluating a function with parameters that are simple atomic types (meta:string) where the parameter argument is the value of a flag node will thrown an exception because the conversion (required by the XPath 3.1 specification) is not completely implemented.

Who is the bug affecting

Developers using Metapath functions with complex arguments and developers supporting it with supporting code in metaschema-java.

How do we replicate this issue

  1. Write a function that has a parameter with a simple atomic type.
  2. Evaluate the instance of a function with a parameter argument that is flag node item's value.
  3. Observe a stack trace that will resemble the one below.

Expected behavior (i.e. solution)

The value of the flag node item is deferenced correctly per the rules, the value is consumed by function evaluation, and no exception is thrown.

Other comments

(NOTE: Re replicating the issue, a unit test with a simpler model to reproduce the bug without full OSCAL models and external constraints, where this issue was originally detected, is forthcoming. This issue and its ID will be used to provide the unit test with a deep link to this bug report.)
@aj-stein-gsa aj-stein-gsa added bug Something isn't working java Pull requests that update Java code labels Dec 31, 2024
@aj-stein-gsa aj-stein-gsa self-assigned this Dec 31, 2024
@david-waltermire david-waltermire moved this from To Triage to Ready in Spec and Tooling Work Board Jan 2, 2025
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 3, 2025
@aj-stein-gsa
Update test and mock flag def builder for metaschema-framework#323
0c60d88
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 3, 2025
@aj-stein-gsa
Update test and mock flag def builder for metaschema-framework#323
7df627b
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 3, 2025
@aj-stein-gsa
Update JavaDoc with correct Metapath flag for metaschema-framework#323
2dbf006
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 3, 2025
@aj-stein-gsa
[skip ci] Formatting IDMFlagNodeItem for metaschema-framework#323
3b31753
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 3, 2025
@aj-stein-gsa
[WIP] Add missing getValue impl in DefinitionFlagNodeItem for metasch…
cce8558 
…ema-framework#323
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 3, 2025
@aj-stein-gsa
Adjust proper test for only flag, not complex doc for metaschema-fram…
4747a71 
…ework#323
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 3, 2025
@aj-stein-gsa
[WIP] Not a full document, adjust paths and vars for metaschema-frame…
0aac252 
…work#323 flag test
@david-waltermire david-waltermire added this to the v2.2.0 milestone Jan 4, 2025
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
Update test and mock flag def builder for metaschema-framework#323
4f8371b
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
Update JavaDoc with correct Metapath flag for metaschema-framework#323
1d1bfeb
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
[skip ci] Formatting IDMFlagNodeItem for metaschema-framework#323
b30b489
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
[WIP] Add missing getValue impl in DefinitionFlagNodeItem for metasch…
4110253 
…ema-framework#323
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
Adjust proper test for only flag, not complex doc for metaschema-fram…
8720392 
…ework#323
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
[WIP] Not a full document, adjust paths and vars for metaschema-frame…
b421fcc 
…work#323 flag test
This was linked to pull requests Jan 7, 2025
Fix parsing of parameter handling for functions with multiple parameters #321
Merged
Update test and mock flag def builder for #323 #332
Merged
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
Update test and mock flag def builder for metaschema-framework#323
d0ea13a
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
Update JavaDoc with correct Metapath flag for metaschema-framework#323
a2f41dc
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
[skip ci] Formatting IDMFlagNodeItem for metaschema-framework#323
9977721
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
[WIP] Add missing getValue impl in DefinitionFlagNodeItem for metasch…
f7c76e4 
…ema-framework#323
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
Adjust proper test for only flag, not complex doc for metaschema-fram…
fc79dd9 
…ework#323
david-waltermire pushed a commit to aj-stein-gsa/metaschema-java that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
[WIP] Not a full document, adjust paths and vars for metaschema-frame…
feb56f7 
…work#323 flag test
david-waltermire added a commit that referenced this issue Jan 7, 2025
@aj-stein-gsa @david-waltermire
Update test and mock flag def builder for #323 (#332)
5f2dbdd 
* Update test and mock flag def builder for #323
* Adjust proper test for only flag, not complex doc for #323
* Refactored some class locations to make them easier to locate.

---------

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
@david-waltermire david-waltermire mentioned this issue Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aj-stein-gsa aj-stein-gsa

Labels
bug Something isn't working java Pull requests that update Java code
Projects
Spec and Tooling Work Board
Archived in project
Milestone
v2.2.0
2 participants
@david-waltermire @aj-stein-gsa