Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string-join & contains #298

Closed
3 tasks
wandmagic opened this issue Dec 16, 2024 · 3 comments · Fixed by #302
Closed
3 tasks

string-join & contains #298

wandmagic opened this issue Dec 16, 2024 · 3 comments · Fixed by #302
Assignees
@aj-stein-gsa
Labels
enhancement New feature or request
Milestone
v2.2.0

Comments

@wandmagic
Copy link
Contributor

User Story

as a metapath user, string-join and contains would allow me to improve constraint quality downstream

Goals

impliment string-join and contains

Dependencies

unit tests

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

Revisions

No response
@wandmagic wandmagic added the enhancement New feature or request label Dec 16, 2024
@aj-stein-gsa
Copy link
Contributor

Just a heads up: contains is already implemented and release, but maybe not string-join but need to check PRs. If the latter is coded, I do know it is not released yet, @wandmagic.

metaschema-java/core/src/main/java/gov/nist/secauto/metaschema/core/metapath/function/library/FnContains.java

Line 27 in 964b845

public final class FnContains {

@wandmagic
Copy link
Contributor Author

thats great news! thanks for letting me know

@aj-stein-gsa
Copy link
Contributor

On that note, it was a real pain to work around some bugs and the use of the bugfix operator in downstream usage of Metapath in FedRAMP OSCAL constraints, so I guess I pick this one up tonight after all. 😅

@aj-stein-gsa aj-stein-gsa self-assigned this Dec 18, 2024
@aj-stein-gsa aj-stein-gsa moved this from To Triage to In progress in Spec and Tooling Work Board Dec 18, 2024
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 18, 2024
@aj-stein-gsa
[WIP] Start of fn-string-join for metaschema-framework#298
f480a8b
@aj-stein-gsa aj-stein-gsa mentioned this issue Dec 18, 2024
Merged
8 tasks
@aj-stein-gsa aj-stein-gsa linked a pull request Dec 18, 2024 that will close this issue
Add implementation of string-join to default function library #302
Merged
8 tasks
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 18, 2024
@aj-stein-gsa
Add fn-string-join impl and tests for metaschema-framework#298
adfa720
@aj-stein-gsa aj-stein-gsa moved this from In progress to In review in Spec and Tooling Work Board Dec 18, 2024
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 19, 2024
@aj-stein-gsa @david-waltermire
Address code review feedback in metaschema-framework#298
ca646a7 
Co-authored-by: David Waltermire <davewaltermire@gmail.com>
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 19, 2024
@aj-stein-gsa
More util fn and fn accessor changes after metaschema-framework#298 P…
2e08db1 
…R feedback
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 19, 2024
@aj-stein-gsa
Add fn-string-join impl and tests for metaschema-framework#298
e038cea
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 19, 2024
@aj-stein-gsa @david-waltermire
Address code review feedback in metaschema-framework#298
88594cd 
Co-authored-by: David Waltermire <davewaltermire@gmail.com>
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 19, 2024
@aj-stein-gsa
More util fn and fn accessor changes after metaschema-framework#298 P…
b17c395 
…R feedback
@aj-stein-gsa aj-stein-gsa mentioned this issue Dec 19, 2024
Closed
7 tasks
david-waltermire added a commit that referenced this issue Dec 19, 2024
@aj-stein-gsa @david-waltermire
Add implementation of string-join to default function library (#302)
5097f0e 
* Add fn-string-join impl and tests for #298

Co-authored-by: David Waltermire <davewaltermire@gmail.com>
@github-project-automation github-project-automation bot moved this from In review to Done in Spec and Tooling Work Board Dec 19, 2024
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 20, 2024
@aj-stein-gsa
Improve Metapath to core util fn interfaces for metaschema-framework#298
4fa4d08
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 20, 2024
@aj-stein-gsa
Improve Metapath to core util fn interfaces for metaschema-framework#298
933a704
aj-stein-gsa added a commit to aj-stein-gsa/metaschema-java that referenced this issue Dec 20, 2024
@aj-stein-gsa
Improve Metapath to core util fn interfaces for metaschema-framework#298
a771e76
@aj-stein-gsa aj-stein-gsa mentioned this issue Dec 20, 2024
Merged
9 tasks
david-waltermire pushed a commit that referenced this issue Dec 28, 2024
@aj-stein-gsa
Improve Metapath to core util fn interfaces for #298 (#310)
cfbd8cf
@david-waltermire david-waltermire added this to the v2.2.0 milestone Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aj-stein-gsa aj-stein-gsa

Labels
enhancement New feature or request
Projects
Spec and Tooling Work Board
Archived in project
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Add implementation of string-join to default function library aj-stein-gsa/metaschema-java
3 participants
@david-waltermire @wandmagic @aj-stein-gsa