Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracked changes: investigation, possibility to reproduce in Apache FOP #64

Open
Intelligent2013 opened this issue Apr 19, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Intelligent2013
Copy link
Contributor

  1. Addition/deletion changes are shown in red and green. Example document: https://shop.bsigroup.com/ProductDetail?pid=000000000030413431

image

image

Supported yet:
1.1. Added text are shown in green color background - tag <add>...</add>, the style (background's color and text's color can be set up in common.xsl)
1.2. Deleted text are shown in red color text - tag <del>...</del>.

To be check:
1.3. Added figure are shown in the green box.
1.4. Deleted figure are shown in the red box with cross.
1.5. Added table are shown in the green box.
1,6. Deleted table are shown in the red box with cross.

  1. The additions are tagged with symbols. Example document: https://civilnode.com/download-standard/10646400567105/bs-8500-1-concrete-complementary-british-standard-to-bs-en-206-part-1-method-of-specifying

image

To be check:
2.1. SVG graphics with dynamic text (for tags) inlined in the text.

@Intelligent2013 Intelligent2013 added enhancement New feature or request question Further information is requested labels Apr 19, 2021
@Intelligent2013 Intelligent2013 self-assigned this Apr 19, 2021
@Intelligent2013
Copy link
Contributor Author

Proposals for MN XML markup:

  1. <add>....</add> - all markup inside these tags will be showed as added thing (green background text, green bordered figure/table)
  2. element level track changes, for example <table track_changes="add">...</table> - table, marked with attribute track_changes="add" will be showed as 'added' (with green border).
  3. clause level track changes, for example <clause track_changes="add">...</clause> - all markup inside clause with attribute track_changes="add" will be showed as added thing.
  4. annex level track changes - similar to 'clause' level track changes.

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Apr 20, 2021
@Intelligent2013
Copy link
Contributor Author

1.3. Added figure are shown in the green box

xslt updated for support 'added' figure. Example:
image

1.4. Deleted figure are shown in the red box with cross.

xslt updated for support 'deleted' figure. Example:
image

(I can't fit 'red crossing' exactly to the border and figure title.)

1.5. Added table are shown in the green box.

xslt updated for support 'added' table. Example:
image

1,6. Deleted table are shown in the red box with cross.

xslt updated for support 'deleted' table, but I can't display red crossing over table. I propose to display 'deleted' table with 'light red' background with red border:
image

or with red border and all text in red.

p.s. xslt should be update later for actual xml element/attribute for added/deleted indication.

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Apr 20, 2021
@Intelligent2013
Copy link
Contributor Author

2.1. SVG graphics with dynamic text (for tags) inlined in the text.

xslt updated. For example source xml (proof-of-concept, just for testing):

<p>
<del>The use of echo cancellers on the VBD channel, as per Rec. ITU-T G.168.</del><add amendment="2">ADDED: The use of echo cancellers on the VBD channel, as per Rec. ITU-T G.168.</add>
</p>
<p>
<add corrigenda="1">ADDED: The use of echo cancellers on the VBD channel, as per Rec. ITU-T G.168.</add>
</p>

image

Xslt should be changed later for actual xml structures.

@ronaldtse
Copy link
Contributor

This looks great. So we will need help from @opoudjis to update the XML and make this work!

@ronaldtse
Copy link
Contributor

ronaldtse commented Apr 29, 2021

xslt updated for support 'deleted' table, but I can't display red crossing over table. I propose to display 'deleted' table with 'light red' background with red border:

@Intelligent2013 I agree, light red background looks more pleasing. Let's go with that.

Also, does the green highlight for "addition of text" work?

@opoudjis
Copy link
Contributor

opoudjis commented May 3, 2021

This looks great. So we will need help from @opoudjis to update the XML and make this work!

We do? This is already implemented, albeit at inline level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants