Fix infinite loop rendering bug (#173)

* Fix infinite loop rendering bug

* Update coveralls syntax

* Remove coveralls

.travis.yml

@@ -10,10 +10,6 @@ node_js:
   - "10"
 jobs:
   include:
-    - stage: coverage
-      node_js: "10"
-      script:
-        - npm run test:coverage
     - stage: lint
       node_js: "10"
       script:

README.md

@@ -1,7 +1,6 @@
 # metalsmith-in-place
 
 [![build status][build-badge]][build-url]
-[![coverage status][coverage-badge]][coverage-url]
 [![greenkeeper][greenkeeper-badge]][greenkeeper-url]
 
 > A metalsmith plugin for transforming your source files
@@ -133,7 +132,5 @@ There are several things that might cause you to get a `no files to process` err
 [build-url]: https://travis-ci.org/metalsmith/metalsmith-in-place
 [greenkeeper-badge]: https://badges.greenkeeper.io/metalsmith/metalsmith-in-place.svg
 [greenkeeper-url]: https://greenkeeper.io/
-[coverage-badge]: https://coveralls.io/repos/github/metalsmith/metalsmith-in-place/badge.svg?branch=master
-[coverage-url]: https://coveralls.io/github/metalsmith/metalsmith-in-place?branch=master
 [slack-url]: http://metalsmith-slack.herokuapp.com/
 [stackoverflow-url]: http://stackoverflow.com/questions/tagged/metalsmith

lib/index.js

@@ -13,6 +13,7 @@ function render({ filename, files, metalsmith, settings }) {
   const file = files[filename];
   const engineOptions = Object.assign({}, settings.engineOptions);
   const metadata = metalsmith.metadata();
+  const isLastExtension = extensions.length === 1;
 
   debug(`rendering ${filename}`);
 
@@ -30,7 +31,7 @@ function render({ filename, files, metalsmith, settings }) {
   const contents = file.contents.toString();
 
   // If this is the last extension, replace it with a new one
-  if (extensions.length === 0) {
+  if (isLastExtension) {
     debug(`last extension reached, replacing last extension with ${transform.outputFormat}`);
     extensions.push(transform.outputFormat);
   }
@@ -57,7 +58,12 @@ function render({ filename, files, metalsmith, settings }) {
 
       debug(`done rendering ${filename}, renamed to ${newName}`);
 
-      // Keep rendering until there are no applicable transformers left
+      // Stop rendering if this was the last extension
+      if (isLastExtension) {
+        return Promise.resolve();
+      }
+
+      // Otherwise, keep rendering until there are no applicable transformers left
       return render({ filename: newName, files, metalsmith, settings });
     })
     .catch(err => {

lib/index.test.js

@@ -9,6 +9,7 @@ const plugin = require('./index');
 describe('metalsmith-in-place', () => {
   beforeEach(() => {
     jest.resetModules();
+    jest.restoreAllMocks();
   });
 
   it('should process a single file', done => {
@@ -28,6 +29,37 @@ describe('metalsmith-in-place', () => {
     });
   });
 
+  it('should stop processing after the last extension has been processed', done => {
+    const base = path.join(process.cwd(), 'test', 'fixtures', 'stop-processing');
+    const actual = path.join(base, 'build');
+    const expected = path.join(base, 'expected');
+    const metalsmith = new Metalsmith(base);
+
+    jest.doMock('./get-transformer', () => () => ({
+      name: 'html',
+      inputFormats: ['html'],
+      outputFormat: 'html',
+      render() {
+        return { body: 'rendered' };
+      },
+      renderAsync() {
+        return Promise.resolve({ body: 'rendered' });
+      }
+    }));
+    // eslint-disable-next-line global-require, no-shadow
+    const plugin = require('./index');
+
+    rimraf.sync(actual);
+
+    return metalsmith.use(plugin()).build(err => {
+      if (err) {
+        return done(err);
+      }
+      expect(() => equal(actual, expected)).not.toThrow();
+      return done();
+    });
+  });
+
   it('should process multiple files', done => {
     const base = path.join(process.cwd(), 'test', 'fixtures', 'multiple-files');
     const actual = path.join(base, 'build');

package.json

@@ -10,8 +10,7 @@
     "precommit": "lint-staged",
     "lint:js": "eslint '**/*.js'",
     "lint:prettier": "prettier --list-different '**/*.js'",
-    "test": "jest",
-    "test:coverage": "jest --coverage && cat ./coverage/lcov.info | coveralls"
+    "test": "jest"
   },
   "jest": {
     "collectCoverageFrom": [
@@ -21,7 +20,6 @@
   "greenkeeper": {
     "ignore": [
       "assert-dir-equal",
-      "coveralls",
       "eslint",
       "eslint-config-airbnb-base",
       "eslint-config-prettier",
@@ -38,7 +36,6 @@
   },
   "devDependencies": {
     "assert-dir-equal": "^1.1.0",
-    "coveralls": "^3.0.0",
     "eslint": "^4.19.1",
     "eslint-config-airbnb-base": "^13.0.0",
     "eslint-config-prettier": "^2.9.0",

test/fixtures/stop-processing/expected/index.html

@@ -0,0 +1 @@
+rendered

test/fixtures/stop-processing/src/index.html

@@ -0,0 +1 @@
+<h2 id="title">Title</h2>