Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow: Temporary autoscaler RBAC workaround #903

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Nov 18, 2024

There is a bug in the autoscaler that makes it get stuck on a permission
issue sometimes. It doesn't really need these permissions for our
use-case, but adding them should hopefully avoid it getting stuck.

See kubernetes/autoscaler#6490

Fixes: #881

There is a bug in the autoscaler that makes it get stuck on a permission
issue sometimes. It doesn't really need these permissions for our
use-case, but adding them should hopefully avoid it getting stuck.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 18, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Discussed offline and also seen this in the logs A LOT. Thanks for the workaround.

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@adilGhaffarDev
Copy link
Member

thank you
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@lentzi90
Copy link
Member Author

Thanks for the reviews!
Adding hold until I have the time to apply and check that it works
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@lentzi90
Copy link
Member Author

It is now applied and looking good. I guess we will know for sure if it worked after a few days.
/hold cancel
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

It is now applied and looking good. I guess we will know for sure if it worked after a few days.
/hold cancel
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit cf7a039 into metal3-io:main Nov 18, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/prow-autoscaler-rbac branch November 18, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prow cluster autoscaler stuck occasionally
4 participants