-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow: Temporary autoscaler RBAC workaround #903
Prow: Temporary autoscaler RBAC workaround #903
Conversation
There is a bug in the autoscaler that makes it get stuck on a permission issue sometimes. It doesn't really need these permissions for our use-case, but adding them should hopefully avoid it getting stuck. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Discussed offline and also seen this in the logs A LOT. Thanks for the workaround.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thank you |
Thanks for the reviews! |
It is now applied and looking good. I guess we will know for sure if it worked after a few days. |
@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There is a bug in the autoscaler that makes it get stuck on a permission
issue sometimes. It doesn't really need these permissions for our
use-case, but adding them should hopefully avoid it getting stuck.
See kubernetes/autoscaler#6490
Fixes: #881