-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow: Configure milestone applier plugin #895
Conversation
This plugin will apply milstones automatically to merged PRs depending on what branch they target. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
/cc @Rozzii |
@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/retitle Prow: Configure milestone applier plugin |
Was the plugin already enabled, and only missed conf? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, Sunnatillo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lentzi90: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
It is one of the built-in plugins. Not sure why they even call them plugins when they are literally compiled in the same binary. In theory you could of course compile it without them but, oh well... |
OK, makes sense then why grepping for milestone never gave results in configs, and we thought it was not even enabled and needed a bit more work. Well, easy win there :) |
This plugin will apply milstones automatically to merged PRs depending on what branch they target.
Fixes: #807