Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow: Configure milestone applier plugin #895

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Nov 8, 2024

This plugin will apply milstones automatically to merged PRs depending on what branch they target.

Fixes: #807

This plugin will apply milstones automatically to merged PRs depending
on what branch they target.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

/cc @Rozzii
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot requested a review from Rozzii November 8, 2024 07:06
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

/cc @Rozzii
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@tuminoid
Copy link
Member

tuminoid commented Nov 8, 2024

/retitle Prow: Configure milestone applier plugin

@metal3-io-bot metal3-io-bot changed the title Prow: Configure milstone applier plugin Prow: Configure milestone applier plugin Nov 8, 2024
@tuminoid
Copy link
Member

tuminoid commented Nov 8, 2024

Was the plugin already enabled, and only missed conf?

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 0d7bda7 into metal3-io:main Nov 8, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/milstone-applier branch November 8, 2024 08:11
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the plugins configmap in namespace prow at cluster default using the following files:

  • key plugins.yaml using file prow/config/plugins.yaml

In response to this:

This plugin will apply milstones automatically to merged PRs depending on what branch they target.

Fixes: #807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Member Author

lentzi90 commented Nov 8, 2024

Was the plugin already enabled, and only missed conf?

It is one of the built-in plugins. Not sure why they even call them plugins when they are literally compiled in the same binary. In theory you could of course compile it without them but, oh well...

@tuminoid
Copy link
Member

tuminoid commented Nov 8, 2024

Was the plugin already enabled, and only missed conf?

It is one of the built-in plugins. Not sure why they even call them plugins when they are literally compiled in the same binary. In theory you could of course compile it without them but, oh well...

OK, makes sense then why grepping for milestone never gave results in configs, and we thought it was not even enabled and needed a bit more work. Well, easy win there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable milestone and milestoneapplier plugins for Prow
6 participants