Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bump golang to 1.23.6 #2320

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

tuminoid
Copy link
Member

This is to get rid of https://osv.dev/GO-2025-3447, where code path is called, but the vulnerability is only on ppc64, so it is not exploitable.

This is to get rid of https://osv.dev/GO-2025-3447, where code path
is called, but the vulnerability is only on ppc64, so it is not
exploitable.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid
Copy link
Member Author

/cherry-pick release-1.9
/cherry-pick release-1.8

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2025
@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.8, release-1.9 in new PRs and assign them to you.

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member Author

/cc @kashifest @lentzi90

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
@metal3-io-bot metal3-io-bot merged commit 5aca0ce into metal3-io:main Feb 12, 2025
16 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-golang-1.23.5 branch February 12, 2025 14:13
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Feb 12, 2025
@metal3-io-bot
Copy link
Contributor

@tuminoid: #2320 failed to apply on top of branch "release-1.8":

Applying: bump golang to 1.23.6
Using index info to reconstruct a base tree...
M	Makefile
A	hack/fake-apiserver/Dockerfile
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): hack/fake-apiserver/Dockerfile deleted in HEAD and modified in bump golang to 1.23.6. Version bump golang to 1.23.6 of hack/fake-apiserver/Dockerfile left in tree.
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 bump golang to 1.23.6

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #2322

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants