Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for dataimage finalizer removal #2053

Open
tuminoid opened this issue Nov 12, 2024 · 4 comments
Open

Add e2e tests for dataimage finalizer removal #2053

tuminoid opened this issue Nov 12, 2024 · 4 comments
Assignees
@hroyrh
Labels
triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member

Via #1974 (comment)

Adding issue so e2e tests are not forgotten.

/assign @hroyrh
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Nov 12, 2024
@tuminoid
Copy link
Member Author

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 12, 2024
@tuminoid tuminoid mentioned this issue Nov 12, 2024
Merged
@tuminoid
Copy link
Member Author

@hroyrh any progress on those tests?

@hroyrh
Copy link
Member

hroyrh commented Jan 21, 2025

@tuminoid just returned to office from by break, will take a look at it now. First, I plan to submit a PR to fix an edge case which was not covered in the earlier fix and then work on the e2e PR.

@tuminoid
Copy link
Member Author

Thank you, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hroyrh hroyrh

Labels
triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tuminoid @hroyrh @metal3-io-bot