Skip to content

Commit

Permalink
Merge pull request #1947 from Nordix/mquhuy/pin-ginkgo-cli-to-package…
Browse files Browse the repository at this point in the history
…-version

🌱 Pin ginkgo cli to test/go.mod ginkgo package
  • Loading branch information
metal3-io-bot authored Sep 26, 2024
2 parents 38b2471 + bbcd4dd commit 4e275c5
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ CRD_OPTIONS ?= "crd:allowDangerousTypes=true,crdVersions=v1"
KUSTOMIZE = tools/bin/kustomize
CONTROLLER_GEN = tools/bin/controller-gen
GINKGO = tools/bin/ginkgo
GINKGO_VER = v2.17.1
DEPLOY_CLI = tools/bin/deploy-cli

# See pkg/version.go for details
Expand Down Expand Up @@ -288,8 +287,8 @@ tools:
go build -o bin/make-bm-worker cmd/make-bm-worker/main.go
go build -o bin/make-virt-host cmd/make-virt-host/main.go

$(GINKGO): ## Install ginkgo in tools/bin
GOBIN=$(abspath tools/bin) go install github.com/onsi/ginkgo/v2/ginkgo@$(GINKGO_VER)
$(GINKGO): ## Install ginkgo in tools/bin. Take ginkgo version from `test/go.mod`.
cd test; GOBIN=$(abspath tools/bin) go install github.com/onsi/ginkgo/v2/ginkgo

## --------------------------------------
## Tilt / Kind
Expand Down

0 comments on commit 4e275c5

Please sign in to comment.