You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I've been looking into using this library for a project of mine and, although it's not a dealbreaker, I'm not a fan of some low-cost transformations that are being used right now to transform between FFI types and Rust types (e.g. Quad to fz_quad using Quad's From<fz_quad> impl).
I feel like a lot (if not all) of these transformations could be replaced with zerocopy's transmute (or at least proved to be safe and unlock other zero-cost transformations with zerocopy's traits). I've already implemented this in a few places in this codebase locally and think it could improve things.
Are you open to a PR that does this sort of thing?
The text was updated successfully, but these errors were encountered:
Hi, I've been looking into using this library for a project of mine and, although it's not a dealbreaker, I'm not a fan of some low-cost transformations that are being used right now to transform between FFI types and Rust types (e.g.
Quad
tofz_quad
usingQuad
'sFrom<fz_quad>
impl).I feel like a lot (if not all) of these transformations could be replaced with zerocopy's
transmute
(or at least proved to be safe and unlock other zero-cost transformations with zerocopy's traits). I've already implemented this in a few places in this codebase locally and think it could improve things.Are you open to a PR that does this sort of thing?
The text was updated successfully, but these errors were encountered: