Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timebox Hidden Promotions #1601

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Timebox Hidden Promotions #1601

merged 2 commits into from
Feb 5, 2025

Conversation

sidharthv96
Copy link
Member

📑 Summary

Configure hide duration for promotion banners.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit 0b1dd4b
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/67a258b1bfa8eb00086cb84a
😎 Deploy Preview https://deploy-preview-1601--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Feb 4, 2025

Mermaid Live Editor    Run #1811

Run Properties:  status check passed Passed #1811  •  git commit e7bf9acd16 ℹ️: Merge 0b1dd4b06d6e062d114d90ecb85f584bd09b25e7 into 1b7065609b72801ca63d1e8906db...
Project Mermaid Live Editor
Branch Review sidv/hidePromotions
Run status status check passed Passed #1811
Run duration 01m 48s
Commit git commit e7bf9acd16 ℹ️: Merge 0b1dd4b06d6e062d114d90ecb85f584bd09b25e7 into 1b7065609b72801ca63d1e8906db...
Committer Sidharth Vinod
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 6
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29
View all changes introduced in this branch ↗︎

@sidharthv96 sidharthv96 merged commit 276b49e into develop Feb 5, 2025
11 checks passed
@sidharthv96 sidharthv96 deleted the sidv/hidePromotions branch February 5, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants