struct DisjointMut: unsafe impl Send + Sync
#1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
kkysen/mod-disjoint_mut-remove-allow-unused
to
main
July 15, 2024 18:30
rinon
reviewed
Jul 16, 2024
kkysen
force-pushed
the
kkysen/struct-DisjointMut-Send-Sync
branch
from
bb9cd1c to
ff5f0e7
Compare
kkysen
force-pushed
the
kkysen/struct-DisjointMut-Send-Sync
branch
from
ff5f0e7 to
7eae462
Compare
|
Do we need the |
|
I think we need to require it. If that pointer is indeed safe to share we need to mark it as such. |
rinon
approved these changes
Jul 16, 2024
It's not safe, though. That's the problem. |
|
Let me think about it some more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this reasoning make sense?
In particular, I'm unsure about the provenanceless thing and data races not leading to memory unsafety. Is this worth it to say? Is it worth it to add an
unsafe trait Provenancelessto ensure such a thing at a more detailed level? I do think it's an important point that data races won't lead to memory unsafety, though.