See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. Please remove blank lines at end of 'samples/bluetooth/peripheral_mds/memfault_config/memfault_platform_config.h' Please remove blank lines at end of 'samples/debug/memfault/config/memfault_platform_config.h'

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 48e6655c2da0fd8f7b3d96ad3def262bace8149d: author email (Gillian Minnehan <gillian@memfault.com>) needs to match one of the signed-off-by entries.

See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details. Undefined Kconfig symbols: warning: undefined symbol MEMFAULT_HTTP_ENABLE: - Referenced at /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/subsys/bluetooth/services/Kconfig.mds:7: menuconfig BT_MDS bool "Memfault Diagnostic service" select BT_NRF_SERVICES depends on !MEMFAULT_HTTP_ENABLE && BT help Enable GATT Memfault Diagnostic BLE service. warning: undefined symbol MEMFAULT: - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:9: config MEMFAULT_HTTP_USES_MBEDTLS bool default n if NRF_MODEM_LIB depends on MEMFAULT - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:13: config MEMFAULT_NCS_PROJECT_KEY string "Memfault API key" depends on MEMFAULT help Memfault project key - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:18: choice bool "Choose built-in Memfault Device Info or custom implementation" default MEMFAULT_DEVICE_INFO_BUILTIN depends on MEMFAULT - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:36: choice bool "Memfault device ID generation method" default MEMFAULT_NCS_DEVICE_ID_IMEI if BOARD_NRF9160DK_NRF9160_NS || BOARD_NRF9161DK_NRF9161_NS || BOARD_THINGY91_NRF9160_NS default MEMFAULT_NCS_DEVICE_ID_NET_MAC if BOARD_NRF7002DK_NRF5340_CPUAPP default MEMFAULT_NCS_DEVICE_ID_STATIC depends on MEMFAULT - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:66: config MEMFAULT_NCS_DEVICE_ID string "Memfault device ID" depends on MEMFAULT_NCS_DEVICE_ID_STATIC && MEMFAULT help Memfault device ID - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:72: config MEMFAULT_NCS_DEVICE_ID_MAX_LEN int "Memfault device ID max length" default 30 depends on MEMFAULT_NCS_DEVICE_ID_RUNTIME && MEMFAULT help Maximum length for the device ID when CONFIG_MEMFAULT_NCS_DEVICE_ID_RUNTIME is selected as method for device ID generation - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:80: config MEMFAULT_NCS_HW_VERSION string "Hardware version" default "nrf9160dk" if BOARD_NRF9160DK_NRF9160_NS default "nrf9161dk" if BOARD_NRF9161DK_NRF9161_NS default "thingy91" if BOARD_THINGY91_NRF9160_NS default BOARD depends on MEMFAULT help Device hardware version - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:89: config MEMFAULT_NCS_FW_TYPE string "Firmware type" default "nrf91ns-fw" if SOC_SERIES_NRF91X default "nrf7002_nrf53-fw" if BOARD_NRF7002DK_NRF5340_CPUAPP default "nrf-ble-fw" if BT_MDS depends on MEMFAULT help Firmware type running on the board - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:97: choice MEMFAULT_FW_VERSION bool "Firmware version generation method" default MEMFAULT_NCS_FW_VERSION_AUTO depends on MEMFAULT help Method to use to generate firmware version - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:116: config MEMFAULT_NCS_FW_VERSION_PREFIX string "Firmware version prefix" default "0.0.1+" depends on MEMFAULT_NCS_FW_VERSION_AUTO && MEMFAULT help Prefix to use in front of automatically generated build version string. If the build version string is "a1b2c3d", the full firmware version will become "<prefix>a1b2c3d". - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:125: config MEMFAULT_NCS_FW_VERSION string "Static firmware version to use" depends on MEMFAULT_NCS_FW_VERSION_STATIC && MEMFAULT help When using a statically configured firmware version, this value will be reported to Memfault - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:132: config MEMFAULT_NCS_INIT_PRIORITY int "Memfault initialization priority" default 90 depends on MEMFAULT - Referenced at ../nrf/modules/memfault-firmware-sdk/Kconfig:136: config MEMFAULT_NCS_PROVISION_CERTIFICATES bool "Provision certificates on initalization" default y if MEMFAULT_ROOT_CERT_STORAGE_NRF9160_MODEM depends on MEMFAULT help Provision required TLS root certificates for connecting to Memfault's endpoints. If this option is disabled, the user is re

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details 1: UC2 Commit message does not contain a 'Signed-off-by:' line 5: UC4 Commit message body line exceeds max length (86>72): " In Memfault SDK 1.19.0, the config `MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS` set via" 6: UC4 Commit message body line exceeds max length (110>72): " `memfault_platform_config.h` was replaced with the Kconfig `CONFIG_MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS`." 8: UC4 Commit message body line exceeds max length (125>72): " - Removes debug module Kconfig in the asset tracker app for the hearbeat interval, this is unnecessary wrapping now that the" 11: UC4 Commit message body line exceeds max length (74>72): " - Adds example usage of `CONFIG_MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS`" 18: UC4 Commit message body line exceeds max length (94>72): " west build -b thingy91/nrf9160/ns --sysbuild -p always nrf/applications/asset_tracker_v2 -- \" 19: UC4 Commit message body line exceeds max length (85>72): " -DCONFIG_MEMFAULT_NCS_PROJECT_KEY=\"$(<~/.memfault-gilly-playground-proj-key)\" \"

Git conflict markers and whitespace errors are not allowed in added changes 48e6655c2da0fd8f7b3d96ad3def262bace8149d: samples/bluetooth/peripheral_mds/memfault_config/memfault_platform_config.h:11: new blank line at EOF. 48e6655c2da0fd8f7b3d96ad3def262bace8149d: samples/debug/memfault/config/memfault_platform_config.h:14: new blank line at EOF.

Process completed with exit code 1.