Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content: publish zephyr kconfig article #423

Merged
merged 1 commit into from
Jan 24, 2024
Merged

content: publish zephyr kconfig article #423

merged 1 commit into from
Jan 24, 2024

Conversation

gminn
Copy link
Member

@gminn gminn commented Jan 23, 2024 •
edited
Loading

  • Adjusted grammar and punctuation for clarity
  • Adjusted some spacing found by a markdown linter --> should look at adding this to a pre-commit hook!

@gminn gminn force-pushed the gminn/publish-zephyr-part2 branch from 8f7ef0d to c9d6c0f Compare January 23, 2024 21:28
@gminn gminn marked this pull request as ready for review January 23, 2024 21:30
@gminn gminn requested a review from bahildebrand January 23, 2024 21:30
@gminn
Copy link
Member Author

gminn commented Jan 23, 2024

@lmapii I've applied a few grammar tweaks and formatting adjustments. Let me know what you think!

@lmapii
Copy link
Contributor

lmapii commented Jan 24, 2024

Looks good, thank you for the adjustments!

bahildebrand
bahildebrand approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@bahildebrand bahildebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great article. Great work @lmapii !

@gminn gminn merged commit 94ec0a1 into master Jan 24, 2024
5 checks passed
@lmapii
Copy link
Contributor

lmapii commented Jan 24, 2024 •
edited
Loading

Very happy this is moving along, thank you so much for your time and help!

@nihalgonsalves nihalgonsalves deleted the gminn/publish-zephyr-part2 branch February 28, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmapii lmapii lmapii left review comments

@bahildebrand bahildebrand bahildebrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gminn @lmapii @bahildebrand