Skip to content

Commit

Permalink
Merge #94
Browse files Browse the repository at this point in the history
94: Add missing `image.pullSecret` entry in Readme table r=alallema a=renehernandez

Small PR to update the Readme with the missing `image.pullSecret` entry in the Readme table.

Also set the default value for `image.pullSecret` to null

Co-authored-by: Rene Hernandez Remedios <rene.hernandez@fullscript.com>
  • Loading branch information
bors[bot] and Rene Hernandez Remedios authored Jan 6, 2022
2 parents 9c703ed + 67c2ea0 commit c72d257
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/meilisearch/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: "v0.24.0"
description: A Helm chart for the Meilisearch search engine
name: meilisearch
version: 0.1.22
version: 0.1.23
icon: https://res.cloudinary.com/meilisearch/image/upload/v1597822872/Logo/logo_img.svg
home: https://github.com/meilisearch/meilisearch-kubernetes/charts
maintainers:
Expand Down
2 changes: 2 additions & 0 deletions charts/meilisearch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ helm uninstall <your-service-name>
| | |
| `image.pullPolicy` | MeiliSearch image pull policy | `IfNotPresent`
| | |
| `image.pullSecret` | Secret to authenticate against the docker registry | '' |
| | |
| `serviceAccount.annotations` | Additional annotations for service account | `{}`
| | |
| `ingress.enabled` | Enable ingress controller resource | `false`
Expand Down
1 change: 1 addition & 0 deletions charts/meilisearch/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ image:
repository: getmeili/meilisearch
tag: v0.24.0
pullPolicy: IfNotPresent
pullSecret:

nameOverride: ""
fullnameOverride: ""
Expand Down

0 comments on commit c72d257

Please sign in to comment.