Fix:fix bug limit special

mehdi-fathi · Apr 9, 2021 · 406532c · 406532c
1 parent 6c4ff0c
commit 406532c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/src/QueryFilter/Queries/Special.php b/src/QueryFilter/Queries/Special.php
@@ -28,17 +28,17 @@ class Special extends BaseClause
      */
     public function apply($query): Builder
     {
-        foreach ($this->values as $key => $param) {
+        foreach ($this->values as $key => $param_value) {
             if (!in_array($key, self::$reserve_param['f_params'])) {
                 throw new \Exception("$key is not in f_params array.");
             }
-            if (is_array($param)) {
+            if (is_array($param_value)) {
                 $this->values['orderBy']['field'] = explode(',', $this->values['orderBy']['field']);
                 foreach ($this->values['orderBy']['field'] as $order_by) {
                     $query->orderBy($order_by, $this->values['orderBy']['type']);
                 }
             } else {
-                $query->limit($this->values);
+                $query->limit($param_value);
             }
         }
 

diff --git a/tests/Tests/ModelFilterMockTest.php b/tests/Tests/ModelFilterMockTest.php
@@ -290,7 +290,23 @@ public function testFParamOrder()
             ],
         ]);
 
-        //todo ye default asc vase type order bezar
+        $users = EloquentBuilderTestModelParentStub::filter($this->request->query());
+
+        $this->assertSame($users->toSql(), $builder->toSql());
+    }
+
+    public function testFParamLimit()
+    {
+        $builder = new EloquentBuilderTestModelParentStub();
+
+        $builder = $builder->newQuery()
+            ->limit(5);
+
+        $this->request->shouldReceive('query')->andReturn([
+            'f_params' => [
+                'limit' => 5,
+            ],
+        ]);
 
         $users = EloquentBuilderTestModelParentStub::filter($this->request->query());