fix(response) Remove JsonStandard response type

meeio-app · Dec 4, 2024 · d0c2a0c · d0c2a0c
1 parent c91cdb3
commit d0c2a0c
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 108 deletions.
diff --git a/config/packages/nelmio_cors.yaml b/config/packages/nelmio_cors.yaml
@@ -1,18 +1,11 @@
 nelmio_cors:
     defaults:
-        allow_origin: ["*"]
+        allow_credentials: true
+        origin_regex: false
+        allow_origin: ["%env(CORS_ALLOW_ORIGIN)%"]
+        allow_methods: ["GET", "OPTIONS", "POST", "PUT", "PATCH", "DELETE"]
+        allow_headers: ["Content-Type", "Authorization", "Accept"]
+        expose_headers: ["Link"]
+        max_age: 3600
     paths:
         "^/": null
-
-when@prod:
-    nelmio_cors:
-        defaults:
-            allow_credentials: true
-            origin_regex: false
-            allow_origin: ["%env(CORS_ALLOW_ORIGIN)%"]
-            allow_methods: ["GET", "OPTIONS", "POST", "PUT", "PATCH", "DELETE"]
-            allow_headers: ["Content-Type", "Authorization", "Accept"]
-            expose_headers: ["Link"]
-            max_age: 3600
-        paths:
-            "^/": null
diff --git a/src/Controller/TestController.php b/src/Controller/TestController.php
@@ -17,6 +17,8 @@ class TestController extends AbstractRestController
     #[Route('/test', name: 'test')]
     public function index(Request $request): JsonResponse
     {
+        throw new \Exception('Test');
+
         return $this->json(null);
     }
 }
diff --git a/src/Enum/ContentType.php b/src/Enum/ContentType.php
diff --git a/src/EventSubscriber/ExceptionSubscriber.php b/src/EventSubscriber/ExceptionSubscriber.php
@@ -6,6 +6,7 @@
 
 use Psr\Log\LoggerInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
@@ -30,11 +31,11 @@ public function onKernelException(ExceptionEvent $event): void
         $exception = $event->getThrowable();
         $statusCode = $exception instanceof HttpExceptionInterface ? $exception->getStatusCode() : Response::HTTP_INTERNAL_SERVER_ERROR;
 
-        $response = new Response(
-            json_encode([
+        $response = new JsonResponse(
+            [
                 'message' => Response::$statusTexts[$statusCode],
                 'details' => $exception->getMessage(),
-            ]),
+            ],
             $statusCode
         );
 

diff --git a/src/EventSubscriber/ResponseSubscriber.php b/src/EventSubscriber/ResponseSubscriber.php
diff --git a/src/Factory/FlashcardFactory.php b/src/Factory/FlashcardFactory.php
@@ -2,8 +2,6 @@
 
 declare(strict_types=1);
 
-declare(strict_types=1);
-
 namespace App\Factory;
 
 use App\Entity\Flashcard;

diff --git a/src/MessageHandler/SendTextEmailMessageHandler.php b/src/MessageHandler/SendTextEmailMessageHandler.php
@@ -24,7 +24,7 @@ public function __construct(
     public function __invoke(SendTextEmailMessage $message): void
     {
         $email = (new Email())
-            ->from('noreply@example.com')
+            ->from($this->sender)
             ->to($message->email)
             ->priority($message->priority)
             ->subject($message->subject)