Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden CI #3

Merged
merged 2 commits into from
Apr 5, 2025
Merged

Harden CI #3

merged 2 commits into from
Apr 5, 2025

Conversation

medmunds
Copy link
Owner

@medmunds medmunds commented Apr 4, 2025

Improve CI workflow security

@medmunds medmunds requested a review from Copilot April 4, 2025 23:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/ci.yml:9

  • Setting global permissions to an empty object disables all automatic permissions; ensure that every job explicitly defines all required permissions to avoid unintentional behavior.
permissions: {}

.github/workflows/ci.yml:195

  • Verify that the conditional expression for the 'Cache Unicode data' step is correctly closed with matching parentheses and curly braces to ensure the condition works as intended.
          github.event_name == 'push' && github.ref == 'refs/heads/main' &&

Publish all pushes to TestPyPI.
Require successful TestPyPI publishing before production publish job.
@medmunds medmunds merged commit 248a1e0 into main Apr 5, 2025
13 checks passed
@medmunds medmunds deleted the task/harden-ci branch April 5, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant