This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Gather APIKey from secret #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, was thinking about that too already… it would be a bit nicer to maybe support old and new style, but I guess a breaking changes release doesn't hurt either. |
|
Yeah, right. I am quite busy right now, but will work on the backwards compatibility. It should be rather easy. |
Signed-off-by: Justin Lamp <justin.lamp@netways.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the apiKey will now be fetched from a secret instead of keeping it in the clusterissuer.