Demonstrate wrapping with asIntN/asUintN Bigint static methods #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-rowe
requested review from
chrisdavidmills
and removed request for
a team
lionel-rowe
force-pushed
the
bigint-asintn-asuintn
branch
from
cd19e90 to
39021dc
Compare
chrisdavidmills
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Hi @lionel-rowe, and thanks for your contribution to MDN.
I've tested the examples — they work as advertised, and are the right size to fit into the live example widget.
I'd also like to get a comment on this from someone who knows more than me about JS language mechanics, like @Josh-Cena.
Josh-Cena
approved these changes
Sep 2, 2024
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demonstrate wrapping with asIntN/asUintN Bigint static methods
Motivation
Current examples fail to demonstrate the main use case for
asIntNandasUintN, namely wrapping. Thenumber > maxcheck in the function means the number will never wrap, so there's no point in callingasIntN/asUintN. Also, the check is buggy, given that it only checks the max and not the min (-1ndoesn't fit in a u64, and-9223372036854775809ndoesn't fit in an i64, yet neither would trigger the "Number doesn't fit" path).Additional details
N/A
Related issues and pull requests
N/A