Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove @@notation from user-facing example titles #2808

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Josh-Cena
Copy link
Member

Part of mdn/mdn#562. This PR only changes user-facing strings, without touching any file paths.

@Josh-Cena Josh-Cena requested a review from a team as a code owner July 15, 2024 03:14
@Josh-Cena Josh-Cena requested review from teoli2003 and bsmth and removed request for a team and teoli2003 July 15, 2024 03:14
@Josh-Cena
Copy link
Member Author

I don't really know who to request for reviews, so I'm just randomly fetching @bsmth 😄

@bsmth bsmth changed the title Remove @@notation from user-facing example titles feat: Remove @@notation from user-facing example titles Jul 15, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we reference this in content? Same as the other deletion below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't. We removed these two pages long ago, which is why I'm simply removing the examples.

@bsmth bsmth self-requested a review July 15, 2024 16:57
@bsmth
Copy link
Member

bsmth commented Jul 15, 2024

LGTM, thank you!

@Josh-Cena Josh-Cena merged commit 0d30bc2 into mdn:main Jul 15, 2024
5 checks passed
@Josh-Cena Josh-Cena deleted the rm-at-at-title branch July 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants