Skip to content

Fix example code for picker-icon and checkmark pseudo-elements #39041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

lucasweng
Copy link
Contributor

@lucasweng lucasweng commented Apr 8, 2025

Description

This PR updates the example code for picker-icon and checkmark to match their respective descriptions. The correct selector should be ::picker(select) for the styling to work properly.

Animating the picker icon

To opt-in to customizable select functionality, the <select> element and its picker both need to have an appearance value of base-select set on them:

select,
::picker-icon(select) {
 appearance: base-select;
}

Customizing the checkmark

To opt-in to customizable select functionality, the <select> element and its picker both need to have an appearance value of base-select set on them:

select,
::checkmark(select) {
  appearance: base-select;
}

Motivation

Additional details

Related issues and pull requests

@lucasweng lucasweng requested a review from a team as a code owner April 8, 2025 14:31
@lucasweng lucasweng requested review from estelle and removed request for a team April 8, 2025 14:31
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Apr 8, 2025
@lucasweng lucasweng changed the title Fix example code for picker-icon pseudo-element Fix example code for picker-icon and checkmark pseudo-elements Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks

@Josh-Cena Josh-Cena merged commit e70bdcc into mdn:main Apr 9, 2025
8 checks passed
@lucasweng lucasweng deleted the picker-icon-example branch April 9, 2025 16:25
cssinate pushed a commit to cssinate/content that referenced this pull request Apr 11, 2025
…9041)

* Fix example code for picker-icon pseudo-element

* Fix example code for checkmark pseudo-element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants