clarified code example: removed unnecessary button type #38157
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code example was misleading (Exhibit A: I was misled by it). How so: - The button type attribute is known to carry behavior w.r.t. its ancestor element (button.type=submit will submit a <form> etc. ; see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#type ) - The documentation page is all about closing a <dialog> and raising the cancel event. - The presence of a <button type="reset"> in the example suggests that the type attribute does actually contribute to the button behavior w.r.t. the <dialog> - but it does nothing, the closing of the dialog is only the result of a click listener attached via script
teetotum
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
|
Preview URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code example was misleading (Exhibit A: I was misled by it). How so:
<form>etc. ; see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#type )<dialog>and raising the cancel event.<button type="reset">in the example suggests that the type attribute does actually contribute to the button behavior w.r.t. the<dialog>Description
I removed the attribute
type="reset"in the code example, as I think it is confusing, even misleading.Motivation
I was misled by it. I want to spare others the same confusion in the interpretation of the code example.
Additional details
I consulted the documentation for button.type to understand whether I missed anything
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#type
Related issues and pull requests
probably nothing related to it