-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin differentiating between two same-named guides #38009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle I am a bit confused by this PR. The two guides with the same name — do they both still exist, or have they been consolidated?
In this PR, you seem to be using different text labels for links that point to the same place.
- The
justify-content
page has this link —[Box alignment in grid layout](/en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_grid_layout)
- The
display
page has this link —[Aligning items in CSS grid layout](/en-US/docs/Web/CSS/CSS_grid_layout/Box_alignment_in_grid_layout)
— which redirects to /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_grid_layout anyway.
I don't get the point of these differing links if they all end up at the same place.
@chrisdavidmills There are currently two guides with the exact same title on MDN. One is in CSS box alignment. The other is in CSS grid layout. I am changing the name of the one in the grid directory. And updating all the links to both so they point to the one that makes more sense in their context. /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_grid_layout This project changes the links to point to the right doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's do this then.
Two guides had the exact same name. This changes some of the links to the guide more appropriate for the content and changes the name of the guide for the links pointing to the grid item alignment guide.
The guide is updated in #38004 - this is just for links to the guide
Part of #37999