Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora/SPECS/pam_usb.spec: add BuildRequires #252

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fedora/SPECS/pam_usb.spec
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Version: %{version}
Release: %{release}
Prefix: /usr
Group: System Environment/Base
BuildRequires: rsync libudisks2-devel libxml2-devel
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rsync?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the rsync command is called in the fedora spec @mcdope .

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, forgot about that - sorry :D

But actually, we should change that to use regular cp instead. I don't see the need to use rsync there.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna accept the change and will create a ticket to get rid of rsync for that.

Requires: pam python3-gobject gawk

%description
Expand Down Expand Up @@ -87,4 +88,4 @@ rm -rf %{buildroot}/usr/share/pam-configs
- [Bugfix] Check PAM_RHOST if deny_remote is enable to fix vsftpd auth breaking down (#100)
- [Bugfix] Fix type for argument to stat (community contribution)
- [Docs] Added code of conduct (#106) and updated AUTHORS
- [Makefile] Fix LIBDIR on non-debian systems
- [Makefile] Fix LIBDIR on non-debian systems
Loading