#187: [Tools] Add experimental pinentry application

[mcdope]

This adds an experimental pinentry application.

Requirements:
[ ] File ~/.pamusb-pinentry.env, containing the following:
[ ] PINENTRY_PASSWORD=yourGpgKeyPassword
[ ] PINENTRY_FALLBACK_APP=/path/to/fallback/pinentry (eg /usr/bin/pinentry-gnome3 or whatever you're using right now)
[ ] Configure GPG to use this application by setting it in ~/.gnupg/gpg-agent.conf. To do so add pinentry-program /path/to/pamusb-pinentry

Note: This MR is work-in-progress

[DhruvaSambrani]

update-alternatives is an ubuntu/debian specific thing, iiuc

[mcdope]

Its not required I was referring to the pull request, not my "note to myself". Am Fr., 23. Aug. 2024 um 12:03 Uhr schrieb Dhruva Sambrani < ***@***.***>:

…

update-alternatives is an ubuntu/debian specific thing, iiuc — Reply to this email directly, view it on GitHub <#250 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZI2U3ZVFQBRKQYWKD5R2TZS4CFPAVCNFSM6AAAAABMKVK6Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWG42DQNBYGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[DhruvaSambrani]

Only change is

diff --git a/tools/pamusb-pinentry b/usr/bin/pamusb-pinentry
index 091270c..14878db 100755
--- a/tools/pamusb-pinentry
+++ b/usr/bin/pamusb-pinentry
@@ -19,7 +19,7 @@ import os
 import subprocess
 import getpass
 from dotenv import load_dotenv
-load_dotenv("~/.pamusb-pinentry.env")
+load_dotenv(os.path.expanduser("~/.pamusb-pinentry.env"))
 
 pinentryPassword = os.getenv('PINENTRY_PASSWORD')
 fallbackPinentryApp = os.getenv('PINENTRY_FALLBACK_APP')

Also wouldn't it be better to put the .pamusb-pinentry.env file into the ~/.pamusb folder?

[mcdope]

Yes, it's basically your code - just integrated and installed via `make install`. But does it work like expected? Asking since I can't test pinentry myself because I use gnome-keyring. I would assume so, but I hate merging untested stuff. "Also wouldn't it be better to put the .pamusb-pinentry.env file into the ~/.pamusb folder?" <-- That's actually a very valid point, that also applies to the file for gnome-keyring-unlock even. Gonna adjust both. Am Fr., 23. Aug. 2024 um 12:34 Uhr schrieb Dhruva Sambrani < ***@***.***>:

…

Only change is diff --git a/tools/pamusb-pinentry b/usr/bin/pamusb-pinentry index 091270c..14878db 100755--- a/tools/pamusb-pinentry+++ b/usr/bin/pamusb-pinentry@@ -19,7 +19,7 @@ import os import subprocess import getpass from dotenv import load_dotenv-load_dotenv("~/.pamusb-pinentry.env")+load_dotenv(os.path.expanduser("~/.pamusb-pinentry.env")) pinentryPassword = os.getenv('PINENTRY_PASSWORD') fallbackPinentryApp = os.getenv('PINENTRY_FALLBACK_APP') Also wouldn't it be better to put the .pamusb-pinentry.env file into the ~/.pamusb folder? — Reply to this email directly, view it on GitHub <#250 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZI2UZJYSJJPN77QOW4SMLZS4FZXAVCNFSM6AAAAABMKVK6Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWHAYDGOBQGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[DhruvaSambrani]

The pinentry application works, but the PKGBUILD (and other building stuff) needs to be updated probably?

[mcdope]

Yes and no, they all in the end use "make install" so the file will be installed. However, it's not enabled automatically because it's kinda dirty to touch the config files of another software. Also maybe the user may not want to use it. For systems having `update-alternatives` available it will be chooseable via that, but else users will have to manually adjust their config file. Thanks for verifying, gonna merge this then later. Am Fr., 30. Aug. 2024 um 13:42 Uhr schrieb Dhruva Sambrani < ***@***.***>:

…

The pinentry application works, but the PKGBUILD (and other building stuff) needs to be updated probably? — Reply to this email directly, view it on GitHub <#250 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZI2UYH7DZ2NCU6GKPYSKDZUBLDNAVCNFSM6AAAAABMKVK6Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQHE3DEMJSGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[DhruvaSambrani]

enabling is obviously left to the user, i agree. Just checked the pkgbuild, and it works fine, even if the update-alternatives fails, so all good!

Edit: Ah i see the || exit 0 now, so it doesn't fail. LGTM now. Also sorry for the delay!

[mcdope]

Yeah, exactly. Guess it will still yield a visible error on systems not having it, but it wont cause any issues.

Thanks for your help with this.

Btw, not sure you have noticed: but the script is attributed to you and your name is now in AUTHORS.