feat: accept custom production server build #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 82fbe72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
approved these changes
Aug 13, 2024
|
hey @alanko0511 thanks for the PRs! I'll get a release out once i have a sec to rebase #357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to pass a custom production server build to the request handler. In some situations, you might want to load the server build using a different approach. (for example, use
requireinstead ofimportor pass the object from the memory)We need this because our runtime setup prevents us from using the default dynamic import approach. We would like to have an option that allows us to manually pass the server build without basically building the same
remix-fastifyplugin with the helper functions provided.This parameter is better suited to advanced users, while the default dynamic import approach should be sufficient for normal users.