Fix sapling drops to ignore reduction and obey Knock on Wood #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed here: https://discord.com/channels/526933440214597677/526938425161416727/1213131451235827753 Signed-off-by: Momshroom <Momshroom@gmail.com>
# Conflicts: # src/main/java/com/gmail/nossr50/party/PartyManager.java
…x didn't) Signed-off-by: Momshroom <Momshroom@gmail.com>
nossr50
requested changes
May 23, 2024
nossr50
reviewed
May 23, 2024
nossr50
reviewed
May 23, 2024
src/main/java/com/gmail/nossr50/skills/woodcutting/WoodcuttingManager.java
Outdated
Show resolved
Hide resolved
nossr50
reviewed
May 23, 2024
src/main/java/com/gmail/nossr50/skills/woodcutting/WoodcuttingManager.java
Outdated
Show resolved
Hide resolved
clarified comment clarified location variable name Signed-off-by: Momshroom <Momshroom@gmail.com>
Removed no longer needed dropString variable Signed-off-by: Momshroom <Momshroom@gmail.com>
nossr50
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior fix ignored KnockOnWood and also checked if the block that was dropping things was a sapling, rather than if the drop was. This fixes the issue so that saplings beyond the 25% of blocks will drop if KnockOnWood is unlocked.
(I don't know how to remove the two extra commits from the PR, sorry, but they do cancel each other out)