UML Plugin: Fix incorrect error message when using UML option --uml-no=identity #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the UML option --uml-no=identity as listed as available in the help for UML options, pyang issues the following error message, but correctly renders the UML without identities as expected.
"identity" no valid argument to --uml-no=..., valid arguments: ('module', 'leafref', 'uses', 'annotation', 'identityref', 'typedef', 'import', 'circles', 'stereotypes', 'prefix', 'footer', 'title')This error message is issued becaused the keyword "identity" is not included in the tuple 'nostrings', against which the UML plugin checks the validity of the uml-no arguments.
This fix adds the string "identity" to 'nostrings'. It also reorders the strings (has no effect) to align with the order listed in the help information for easier comparison.
This fix was verified using the module bbf-hardware-types, which contains only feature and identity statements.