Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving GitHub issue 724 #753

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Resolving GitHub issue 724 #753

wants to merge 15 commits into from

Conversation

ygorelik
Copy link
Contributor

@ygorelik ygorelik commented Jul 8, 2021

Resolving GitHub issue #724.

Comment on lines 3 to 4
__version__ = '2.5.0.m1'
__date__ = '2021-07-08'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not modify this file. The version is modified only before release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disregard this file changes. They are relevant only for my private fork.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if you want to merge this PR, this file change will be merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to master version.

@hellt
Copy link

hellt commented Jan 26, 2025

Hi all,
we hit this in https://github.com/pydantify/pydantify project and I am wondering what would be the path forward to get this PR moving again?
Do you prefer a new one raised since this one is 3+ yr old? Or can we work on top of this one?

@ygorelik
Copy link
Contributor Author

@hellt This is all up to the admin of the repository. I have in my fork a working solution, which you can try to use for your application.
I also suggest you to follow development on the issue #724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants