Fix reflang regex pattern to include language code with more than 2 characters #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sipa-echo-zaoa wants to merge 2 commits into mbi:develop from sipa-echo-zaoa:fix-reflang-for-langcode-longer-than-2-characters

sipa-echo-zaoa commented Apr 15, 2025

This pr fixes the following issue: #182

All Submissions:

Are tests passing? (From the root-level of the repository please run pip install tox && tox)
I have added or updated a test to cover the changes proposed in this Pull Request
I have updated the documentation to cover the changes proposed in this Pull Request

sipa-echo-zaoa mentioned this pull request

Reflang might not work with locales longer than 2 symbols. #182

Open

sipa-echo-zaoa added 2 commits

April 15, 2025 13:51


          Fix reflang regex pattern to include language code with more than 2 c…

e2e242a

…haracters.


          Add reflang longer than 2 characters test case.

8d03076

sipa-echo-zaoa force-pushed the fix-reflang-for-langcode-longer-than-2-characters branch from 773bd14 to 8d03076 Compare

April 15, 2025 11:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet