-
Notifications
You must be signed in to change notification settings - Fork 202
Extend django admin templates #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
So, not sure about this one. Why / under which circumstances would it make sense to decouple from the django admin and thus require a fork of the admin templates / statics? 🤔 |
I only mentioned that because I saw there was a ticket about it: #228 And I was just pointing out here that even after this MR it won't really be any more difficult to fork of the admin templates / statics later. And if someone wants to remove the django admin from installed apps then placing these files in their own project's static and template directories would still work too. |
Gotcha thanks! Most of my projects make use of the Django admin, so decoupling and maintaining a fork of Django's admin templates/css/js is not very high on my own personal priorities list for Rosetta. That said, I imagine that the users interested in #228 will take notice of your PR and maybe include it in their forks. |
d81c34a
to
fe44426
Compare
I've just noticed a couple of issues, will sort this out soon:
|
fe44426
to
4a215a5
Compare
That's all sorted now. (The next one will be some basic server side validation if this is merged) |
All Submissions:
pip install tox && tox
)To test it on an existing project:
pip uninstall django-rosetta -y && pip install git+https://github.com/balazs-endresz/django-rosetta.git@extend-django-admin#egg=django-rosetta
This one might be more controversial but if you decide to fully decouple from the django admin later on, then this won't really make that any more difficult either. And at least we'd get consistent styling, dark mode, and likely better support for custom admin themes too.
The template changes were fairly simple, and most of the css is only to fix a lot of minor alignment issues.
Click to show files needed from the django admin, when the django admin is not used
(Btw, you might have missed it but the last two squashed commit messages are not very helpful when looking at the history at a glance.)