Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Exiv2 as static lib #12376

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Build Exiv2 as static lib #12376

merged 1 commit into from
Jan 31, 2025

Conversation

DonLakeFlyer
Copy link
Contributor

Fix #12372

@DonLakeFlyer DonLakeFlyer requested a review from HTRamsey January 30, 2025 22:25
@DonLakeFlyer
Copy link
Contributor Author

@HTRamsey I tried this change but it didn't work. Maybe you have some other ideas on how to use this as a static lib instead of dll.

@HTRamsey
Copy link
Collaborator

HTRamsey commented Jan 30, 2025

It's because I changed it to Find instead of Add, it might find an installed lib, but it's not copying the DLL. Using Add will always build a static lib

@DonLakeFlyer
Copy link
Contributor Author

I've verified this is working on windows now

@DonLakeFlyer DonLakeFlyer merged commit e5dfdac into master Jan 31, 2025
8 checks passed
@DonLakeFlyer DonLakeFlyer deleted the exiv2 branch January 31, 2025 20:09
@rmackay9
Copy link

Thanks very much for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily build fails with "exiv2.dll was not found" error
3 participants