Fix flight modes being announced multiple times, plus others #12307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonLakeFlyer
commented
Jan 8, 2025
| @@ -283,7 +283,6 @@ void Vehicle::_commonInit() | |||
| _vehicleLinkManager = new VehicleLinkManager (this); | |||
|
|
|||
| connect(_standardModes, &StandardModes::modesUpdated, this, &Vehicle::flightModesChanged); | |||
| connect(_standardModes, &StandardModes::modesUpdated, this, [this](){ Vehicle::flightModeChanged(flightMode()); }); | |||
There was a problem hiding this comment.
@bytesByHarsh This was causing the current flight mode when this happens to be announced a second time. I think it's ok to remove this since at worse there could have been a name change on the flight mode. The actual flight mode would not have changed. So the user would have been previously notified of the current flight mode. I don't think there is a need to announce if just the name changed which would be odd anyway.
There was a problem hiding this comment.
Yes true, the flight mode change we have shifted to the firmware plugin class so it should be ok to remove from here.
|
I guess this fixes that reset model warning? |
|
Right |
HTRamsey
approved these changes
Jan 8, 2025
bytesByHarsh
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit text says it all...