gps_global_origin: remove LLA to ECEF conversion #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gps_global_origin is being published as geographic_msgs::GeoPointStamped message, which wants LLA format https://docs.ros.org/en/api/geographic_msgs/html/msg/GeoPointStamped.html FIX mavlink#1381 Signed-off-by: Beniamino Pozzan <b.pozzan@archangel.im>
vooon
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPS_GLOBAL_ORIGIN MAVLink message is published in ROS on the topic
mavros/global_position/gp_originwith type geographic_msgs::GeoPointStamped.This message contains https://docs.ros.org/en/api/geographic_msgs/html/msg/GeoPoint.html and expects
However the messages are published in ECEF coordinates.
This PR removes such conversion matching message requirements and message contents.
FIX #1381