PLAT-25849 Message edits #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`facebookgo` is used for dual-platform mode to make development easier, should be changed back to `meta` in the future
JJTech0130
force-pushed
the
jamesgill/plat-25849
branch
from
24ac1b9 to
c6480fe
Compare
tulir
reviewed
Jul 31, 2024
pkg/connector/msgconv/mentions.go
Outdated
Comment on lines
60
to
68
| mentions, err := rawMentions.Parse() | ||
| if err != nil { | ||
| zerolog.Ctx(ctx).Err(err).Msg("Failed to parse mentions") | ||
|
|
||
| var mentions *socket.Mentions | ||
|
|
||
| if rawMentions != nil { | ||
| mentionsP, err := rawMentions.Parse() | ||
| if err != nil { | ||
| zerolog.Ctx(ctx).Err(err).Msg("Failed to parse mentions") | ||
| } | ||
| mentions = &mentionsP |
There was a problem hiding this comment.
It would be easier to change MentionData.Parse to return nil if the input is nil than add a whole if like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things with
msgconvare starting to get a little bit hairy, should probably rewrite that whole thing...In any case, would really appreciate a review @tulir, some of that edit part stuff I think is not quite right.