Skip to content

Commit

Permalink
build(deps)!: upgrade dependencies to fix vulnerable issues and drop …
Browse files Browse the repository at this point in the history
…support of node 10, 11, 12, 13, 15 (#196)

* fix(deps): remove cz-conventional-changelog due to vulnerable issue

* fix(deps): upgrade jest due to vulnerable issues

* fix(deps): upgrade vulnerable dependencies

* fix(deps): regenerate yarn.lock to apply dependency resolutions due to vulnerable issues

* fix: revert back artifacts.json

* fix(deps): upgrade husky due to vulnerable issue

* test: remove node version jest doesn't support

* test: exclude node 14 on windows

* build: remove the old node versions from build

* chore: leave comments for workflow

* chore: husky hooks

* build: remove the redundant windows build job

* build: remove windows from build workflows

* build: remove windows from any-pr workflows

* docs: add comments for exclusing windows
  • Loading branch information
ivan-mattr authored Jun 22, 2022
1 parent 1bc1402 commit b6c5291
Show file tree
Hide file tree
Showing 10 changed files with 2,711 additions and 4,558 deletions.
14 changes: 2 additions & 12 deletions .github/workflows/any-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,8 @@ jobs:
runs-on: ${{matrix.os}}
strategy:
matrix:
node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x]
os: [windows-latest, macos-latest, ubuntu-latest]
exclude:
# exclude windows node 11 due to neon-sys bug
- os: windows-latest
node-version: 11.x
# exclude windows node 15 due to another node-gyp bug
- os: windows-latest
node-version: 15.x
# exclude windows node 16 due to another node-gyp bug
- os: windows-latest
node-version: 16.x
node-version: [14.x, 16.x]
os: [macos-latest, ubuntu-latest] # not include windows due to node-gyp bug
steps:
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
40 changes: 2 additions & 38 deletions .github/workflows/push-binary-dispatch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,56 +9,20 @@ on:
description: "MacOS Binaries"
required: true
type: boolean
windows:
description: "Windows Binaries"
required: true
type: boolean
linux:
description: "Linux Binaries"
required: true
type: boolean

jobs:
build_win_pub_binaries:
name: Publish Windows binaries for supported environments for release
if: ${{ github.event.inputs.windows == 'true' }}
timeout-minutes: 30
runs-on: ${{matrix.os}}
strategy:
matrix:
node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x]
os: [windows-latest]
exclude:
# exclude windows node 11 due to neon-sys bug
- os: windows-latest
node-version: 11.x
# exclude windows node 15 due to another node-gyp bug
- os: windows-latest
node-version: 15.x
# exclude windows node 16 due to another node-gyp bug
- os: windows-latest
node-version: 16.x
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: yarn
- run: yarn install --frozen-lockfile
- run: yarn build
- run: yarn test
- run: yarn publish:binary
shell: bash
env:
NODE_PRE_GYP_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
build_macos_pub_binaries:
name: Publish MacOS binaries for supported environments for release
if: ${{ github.event.inputs.macos == 'true' }}
timeout-minutes: 30
runs-on: ${{matrix.os}}
strategy:
matrix:
node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x]
node-version: [14.x, 16.x]
os: [macos-latest]
steps:
- uses: actions/checkout@v2
Expand All @@ -80,7 +44,7 @@ jobs:
runs-on: ${{matrix.os}}
strategy:
matrix:
node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x]
node-version: [14.x, 16.x]
os: [ubuntu-latest]
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x]
node-version: [14.x, 16.x]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down
16 changes: 3 additions & 13 deletions .github/workflows/push-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,8 @@ jobs:
runs-on: ${{matrix.os}}
strategy:
matrix:
node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x, 16.x]
os: [windows-latest, macos-latest, ubuntu-latest]
exclude:
# exclude windows node 11 due to neon-sys bug
- os: windows-latest
node-version: 11.x
# exclude windows node 15 due to another node-gyp bug
- os: windows-latest
node-version: 15.x
# exclude windows node 16 due to another node-gyp bug
- os: windows-latest
node-version: 16.x
node-version: [14.x, 16.x]
os: [macos-latest, ubuntu-latest] # not include windows due to node-gyp bug
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand All @@ -45,7 +35,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x]
node-version: [14.x]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down
4 changes: 4 additions & 0 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn commitlint --edit $1
4 changes: 4 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

yarn pretty-quick --staged
1 change: 1 addition & 0 deletions commitlint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = { extends: ["@commitlint/config-conventional"] };
1 change: 0 additions & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ module.exports = {
moduleFileExtensions: ["ts", "tsx", "js", "jsx", "json", "node"],
coveragePathIgnorePatterns: ["<rootDir>/__tests__", "<rootDir>/lib"],
verbose: true,
name: pack.name,
displayName: pack.name,
};
54 changes: 22 additions & 32 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"homepage": "https://github.com/mattrglobal/node-bbs-signatures",
"main": "lib/index.js",
"engines": {
"node": ">=10",
"node": ">=14",
"yarn": "1.x"
},
"directories": {
Expand Down Expand Up @@ -47,55 +47,45 @@
"publish:ts": "./scripts/publish_ts.sh",
"version": "conventional-changelog -p angular -i CHANGELOG.md -s && git add CHANGELOG.md",
"version:release": "yarn version --minor --message \"chore(release): publish\"",
"docs": "typedoc --out docs/api src"
"docs": "typedoc --out docs/api src",
"prepare": "husky install"
},
"devDependencies": {
"@commitlint/cli": "11.0.0",
"@commitlint/config-conventional": "11.0.0",
"@commitlint/cli": "17.0.2",
"@commitlint/config-conventional": "17.0.2",
"@mathquis/node-pre-gyp-github": "1.0.1",
"@stablelib/base64": "1.0.0",
"@stablelib/benchmark": "1.0.0",
"@stablelib/random": "1.0.0",
"@types/jest": "24.0.18",
"@types/jest": "28.1.2",
"@types/node": "12.7.2",
"@typescript-eslint/eslint-plugin": "2.28.0",
"@typescript-eslint/parser": "2.28.0",
"conventional-changelog": "3.1.18",
"conventional-changelog-cli": "2.0.31",
"conventional-changelog": "3.1.25",
"conventional-changelog-cli": "2.2.2",
"copyfiles": "2.2.0",
"cz-conventional-changelog": "3.1.0",
"eslint": "6.8.0",
"eslint-config-prettier": "^6.10.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^3.1.3",
"husky": "4.2.5",
"jest": "24.9.0",
"@mathquis/node-pre-gyp-github": "1.0.1",
"husky": "8.0.1",
"jest": "28.1.1",
"prettier": "2.0.4",
"pretty-quick": "2.0.1",
"rimraf": "3.0.2",
"ts-jest": "24.0.2",
"ts-jest": "28.0.5",
"ts-node": "8.4.1",
"typedoc": "0.17.7",
"typescript": "3.9.3"
},
"husky": {
"hooks": {
"commit-msg": "[[ -n $HUSKY_BYPASS ]] || commitlint -E HUSKY_GIT_PARAMS",
"pre-commit": "[[ -n $HUSKY_BYPASS ]] || pretty-quick --staged"
}
},
"commitlint": {
"extends": [
"@commitlint/config-conventional"
]
},
"config": {
"commitizen": {
"path": "cz-conventional-changelog"
}
"typedoc": "0.22.17",
"typescript": "4.3.3"
},
"dependencies": {
"neon-cli": "0.8.2",
"node-pre-gyp": "0.17.0"
"@mapbox/node-pre-gyp": "1.0.9",
"neon-cli": "0.10.1"
},
"resolutions": {
"neon-cli/**/handlebars": "4.7.7",
"conventional-changelog-cli/**/minimist": "1.2.6",
"conventional-changelog/**/minimist": "1.2.6",
"neon-cli/**/minimist": "1.2.6"
}
}
Loading

0 comments on commit b6c5291

Please sign in to comment.