Skip to content

Commit

Permalink
workflows: sync pull_request trigger types
Browse files Browse the repository at this point in the history
We have "edited" as leftover workaround from days before we had
"PR auto-reapprover" workflow in some jobs. In some jobs it is
specifically needed as those workflows check the PR metadata which is
covered by the edited. Add "ready_for_review" for consistency as
a trigger type as well.

Similar PRs will be pushed across Metal3 repos to make things
consistent after discussion in ironic-image PR.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
  • Loading branch information
tuminoid committed Feb 10, 2025
1 parent 179ac4b commit e299df8
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint-docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Check Markdown links

on:
pull_request:
types: [opened, edited, synchronize, reopened]
types: [opened, reopened, synchronize, ready_for_review]
paths:
- '**.md'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: E2E Test pipeline

on:
pull_request:
types: [opened, edited, synchronize, reopened, ready_for_review]
types: [opened, reopened, synchronize, ready_for_review]
branches:
- 'main'
- 'release-*'
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pr-gh-workflow-approve.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ name: Approve GH Workflows

on:
pull_request_target:
types: [opened, edited, reopened, synchronize]
# edited is needed here as this workflow checks for PR meta content
types: [opened, edited, reopened, synchronize, ready_for_review]

permissions: {}

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pr-verifier.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ permissions: {}

on:
pull_request_target:
types: [opened, edited, reopened, synchronize]
# edited is needed here as this workflow checks for PR meta content
types: [opened, edited, reopened, synchronize, ready_for_review]

jobs:
verify:
Expand Down

0 comments on commit e299df8

Please sign in to comment.