Websocket extension #8585
Open
Websocket extension #8585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
approved these changes
Feb 12, 2025
app/actions/remote/scheduled_post.ts
Outdated
Comment on lines
22
to
23
| const ws = websocketManager.getClient(serverUrl); | ||
| const connectionId = ws?.getConnectionId(); |
There was a problem hiding this comment.
0/5 nitpick
Suggested change
| const ws = websocketManager.getClient(serverUrl); | |
| const connectionId = ws?.getConnectionId(); | |
| const connectionId = websocketManager.getClient(serverUrl)?.getConnectionId(); |
| } | ||
|
|
||
| export async function handleCreateOrUpdateScheduledPost(serverUrl: string, msg: WebSocketMessage<ScheduledPostWebsocketEventPayload>, prepareRecordsOnly = false) { | ||
| try { | ||
| const scheduledPost: ScheduledPost = JSON.parse(msg.data.scheduled_post); | ||
| return handleScheduledPosts(serverUrl, ActionType.SCHEDULED_POSTS.CREATE_OR_UPDATED_SCHEDULED_POST, [scheduledPost], prepareRecordsOnly); | ||
| const scheduledPost: ScheduledPost[] = msg?.data?.scheduledPost ? [JSON.parse(msg.data.scheduledPost)] : []; |
There was a problem hiding this comment.
I think msg is defined in this context. Not so sure about data.
Suggested change
| const scheduledPost: ScheduledPost[] = msg?.data?.scheduledPost ? [JSON.parse(msg.data.scheduledPost)] : []; | |
| const scheduledPost: ScheduledPost[] = msg.data?.scheduledPost ? [JSON.parse(msg.data.scheduledPost)] : []; |
| @@ -51,48 +35,63 @@ afterEach(async () => { | |||
| }); | |||
|
|
|||
| describe('handleCreateOrUpdateSchedulePost', () => { | |||
There was a problem hiding this comment.
It would be nicer to have the tests check if the posts were really created / deleted in the database, but 0/5
Comment on lines
88
to
90
| // default: { | ||
| // getClient: jest.fn(() => mockWebSocketClient), | ||
| // }, |
enahum
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds websocket handling for scheduled post events
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-63111
Checklist
Device Information
ios emulator
Release Note