Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add debug information to object store retries #3576

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix: Add debug information to object store retries #3576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/lib/object_store/src/retries.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ impl Request<'_> {
Ok(result) => break Ok(result),
Err(err) if err.is_retriable() => {
if retries > max_retries {
tracing::warn!(%err, "Exhausted {max_retries} retries performing request; returning last error");
tracing::warn!(?err, "Exhausted {max_retries} retries performing request; returning last error");
break Err(err);
}
tracing::info!(%err, "Failed request, retries: {retries}/{max_retries}");
tracing::info!(?err, "Failed request, retries: {retries}/{max_retries}");
retries += 1;
// Randomize sleep duration to prevent stampeding the server if multiple requests are initiated at the same time.
let sleep_duration = Duration::from_secs(backoff_secs)
Expand Down
Loading