Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): Refactor VM-invoking API server methods to be less VM-specific #3564

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Feb 3, 2025

What ❔

  • Refactors VM-invoking methods in the API server (e.g., gas estimation) to use less VM-specific logic.
  • Simplifies some VM interfaces along the way. E.g., unifies batch and oneshot VM executor results.

Why ❔

Should somewhat simplify ZK OS integration into the API server.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant