Update rubocop-performance requirement from 1.18.0 to 1.19.0 (#399)

Updates the requirements on
[rubocop-performance](https://github.com/rubocop/rubocop-performance) to
permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop-performance/releases">rubocop-performance's
releases</a>.</em></p>
<blockquote>
<h2>RuboCop Performance 1.19.0</h2>
<h3>New features</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/364">#364</a>:
Add new <code>Performance/MapMethodChain</code> cop. (<a
href="https://github.com/koic"><code>@​koic</code></a>)</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/363">#363</a>:
Support safe navigation operator for
<code>Performance/ArraySemiInfiniteRangeSlice</code>,
<code>Performance/DeletePrefix</code>,
<code>Performance/DeleteSuffix</code>, <code>Performance/Detect</code>,
<code>Performance/EndWith</code>,
<code>Performance/InefficientHashSearch</code>,
<code>Performance/MapCompact</code>,
<code>Performance/RedundantSplitRegexpArgument</code>,
<code>Performance/ReverseEach</code>,
<code>Performance/ReverseFirst</code>,
<code>Performance/SelectMap</code>, <code>Performance/Squeeze</code>,
<code>Performance/StartWith</code>,
<code>Performance/StringInclude</code>, and
<code>Performance/StringReplacement</code> cops. (<a
href="https://github.com/koic"><code>@​koic</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md">rubocop-performance's
changelog</a>.</em></p>
<blockquote>
<h2>1.19.0 (2023-08-13)</h2>
<h3>New features</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/364">#364</a>:
Add new <code>Performance/MapMethodChain</code> cop. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/363">#363</a>:
Support safe navigation operator for
<code>Performance/ArraySemiInfiniteRangeSlice</code>,
<code>Performance/DeletePrefix</code>,
<code>Performance/DeleteSuffix</code>, <code>Performance/Detect</code>,
<code>Performance/EndWith</code>,
<code>Performance/InefficientHashSearch</code>,
<code>Performance/MapCompact</code>,
<code>Performance/RedundantSplitRegexpArgument</code>,
<code>Performance/ReverseEach</code>,
<code>Performance/ReverseFirst</code>,
<code>Performance/SelectMap</code>, <code>Performance/Squeeze</code>,
<code>Performance/StartWith</code>,
<code>Performance/StringInclude</code>, and
<code>Performance/StringReplacement</code> cops. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
</ul>
<h2>1.18.0 (2023-05-21)</h2>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/359">#359</a>:
Fix a false positive for
<code>Performance/RedundantEqualityComparisonBlock</code> when the block
variable is used on both sides of <code>==</code>. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/351">#351</a>:
Fix an incorrect autocorrect for <code>Performance/ConstantRegexp</code>
and <code>Performance/RegexpMatch</code> when autocorrecting both at the
same time. ([<a
href="https://github.com/fatkodima"><code>@​fatkodima</code></a>][])</li>
</ul>
<h3>Changes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/357">#357</a>:
Add <code>sort!</code> and <code>minmax</code> to
<code>Performance/CompareWithBlock</code>. ([<a
href="https://github.com/vlad-pisanov"><code>@​vlad-pisanov</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/353">#353</a>:
<strong>(Breaking)</strong> Drop Ruby 2.6 support. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
</ul>
<h2>1.17.1 (2023-04-09)</h2>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/352">#352</a>:
Fix the default config for <code>AllowRegexpMatch</code> option of
<code>Performance/RedundantEqualityComparisonBlock</code>. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
</ul>
<h2>1.17.0 (2023-04-09)</h2>
<h3>New features</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/347">#347</a>:
Add <code>AllowRegexpMatch</code> option to
<code>Performance/RedundantEqualityComparisonBlock</code>. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
</ul>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/346">#346</a>:
Fix a false positive for
<code>Performance/StringIdentifierArgument</code> when using a command
method with receiver. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/344">#344</a>:
Fix <code>Performance/FlatMap</code> autocorrection for chained methods
on separate lines. ([<a
href="https://github.com/fatkodima"><code>@​fatkodima</code></a>][])</li>
</ul>
<h2>1.16.0 (2023-02-06)</h2>
<h3>Changes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/332">#332</a>:
Register offenses for variables against regexes in
<code>Performance/StringInclude</code>. ([<a
href="https://github.com/fatkodima"><code>@​fatkodima</code></a>][])</li>
</ul>
<h2>1.15.2 (2022-12-25)</h2>
<h3>Bug fixes</h3>
<ul>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/313">#313</a>:
Fix a false negative for <code>Performance/RedundantStringChars</code>
when using <code>str.chars.last</code> without argument. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/pull/321">#321</a>:
Fix a false positive for <code>Performance/Sum</code> when using
<code>TargetRubyVersion</code> is 2.3 or lower. ([<a
href="https://github.com/koic"><code>@​koic</code></a>][])</li>
<li><a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/314">#314</a>:
Fix <code>Performance/RegexpMatch</code> to handle
<code>::Regexp</code>. ([<a
href="https://github.com/fatkodima"><code>@​fatkodima</code></a>][])</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/ed66e637d1bcddf6eb8d3ba652e8ad0b88685c49"><code>ed66e63</code></a>
Cut 1.19.0</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/4eba6e961d04775f905eee9a3d705d8001f246fc"><code>4eba6e9</code></a>
Update Changelog</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/6b4d243bd9d1a00b19464ba3ba2ceb2b935dc344"><code>6b4d243</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/364">#364</a>
from koic/add_new_performance_map_method_chain_cop</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/42c78bc62e4537a0fbd6e8c04628d42e7afcb312"><code>42c78bc</code></a>
Add new <code>Performance/MapMethodChain</code> cop</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/d7a141daaeae145c453e64344137f833c8bfc0db"><code>d7a141d</code></a>
Suppress a new RuboCop offense</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/9d56a69f6b6bc11639254eb8e3930f5f2ddac3ea"><code>9d56a69</code></a>
Merge pull request <a
href="https://redirect.github.com/rubocop/rubocop-performance/issues/363">#363</a>
from koic/fix_false_negatives_for_performance_string_...</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/3b4856e221c6b829f70a8b3c2194d16e355ea847"><code>3b4856e</code></a>
Support safe navigation operator for 15 <code>Performance</code>
cops</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/563eb44c085fc1255070a31841c296e6e3ccc46f"><code>563eb44</code></a>
Suppress new <code>Style/ReturnNilInPredicateMethodDefinition</code>
offenses</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/1d22edf4550392efea19346d09a3df9ccd63b2b6"><code>1d22edf</code></a>
Suppress new <code>Style/RedundantRegexpArgument</code> offenses</li>
<li><a
href="https://github.com/rubocop/rubocop-performance/commit/c2713ae4507e66b3b622662e45776e3b40f6da75"><code>c2713ae</code></a>
Use <code>Parser::Ruby32</code> by default for
<code>documentation_syntax_check</code> Rake task</li>
<li>Additional commits viewable in <a
href="https://github.com/rubocop/rubocop-performance/compare/v1.18.0...v1.19.0">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Brictson <matt@mattbrictson.com>

Gemfile

@@ -10,5 +10,5 @@ gem "rubocop", "1.56.0"
 gem "rubocop-md", "1.2.0"
 gem "rubocop-minitest", "0.31.0"
 gem "rubocop-packaging", "0.5.2"
-gem "rubocop-performance", "1.18.0"
+gem "rubocop-performance", "1.19.0"
 gem "rubocop-rake", "0.6.0"

lib/tomo/cli/usage.rb

@@ -26,7 +26,7 @@ def to_s
       attr_reader :banner_proc, :options
 
       def options_help
-        width = options.map(&:first).map(&:length).max
+        width = options.map { |opt| opt.first.length }.max
         options.each_with_object([]) do |(spec, desc), help|
           help << "#{Colors.yellow(spec.ljust(width))}    #{desc}"
         end.join("\n")

lib/tomo/plugin/puma/tasks.rb

@@ -81,7 +81,7 @@ def linger_must_be_enabled!
 
     def setup_directories
       files = [service.path, socket.path].compact
-      dirs = files.map(&:dirname).map(&:to_s)
+      dirs = files.map { |f| f.dirname.to_s }
       remote.mkdir_p dirs.uniq
     end
 

lib/tomo/runtime/settings_interpolation.rb

@@ -39,7 +39,7 @@ def symbolize(hash)
       end
 
       def dump_settings(hash)
-        key_len = hash.keys.map(&:to_s).map(&:length).max
+        key_len = hash.keys.map { |k| k.to_s.length }.max
         dump = "Settings: {\n"
         hash.to_a.sort_by(&:first).each do |key, value|
           justified_key = "#{key}:".ljust(key_len + 1)

lib/tomo/shell_builder.rb

@@ -67,7 +67,7 @@ def command_to_string(*command)
     def shell_join(*command)
       return command.first.to_s if command.length == 1
 
-      command.flatten.compact.map(&:to_s).map(&:shellescape).join(" ")
+      command.flatten.compact.map { |arg| arg.to_s.shellescape }.join(" ")
     end
 
     def cd_chdir