Fix KeyError on unbinding addresses (#397)

matrix-org · Sep 14, 2021 · 2f5a3c5 · 2f5a3c5
1 parent 40bb406
commit 2f5a3c5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/397.bugfix b/changelog.d/397.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in v2.4.0 that caused association unbindings to fail with an Internal Server Error.
diff --git a/sydent/threepid/bind.py b/sydent/threepid/bind.py
@@ -122,7 +122,7 @@ def removeBinding(self, threepid: Dict[str, str], mxid: str) -> None:
         """
 
         # ensure we are casefolding email addresses
-        threepid["address"] = normalise_address(threepid["address"], threepid["email"])
+        threepid["address"] = normalise_address(threepid["address"], threepid["medium"])
 
         localAssocStore = LocalAssociationStore(self.sydent)
         localAssocStore.removeAssociation(threepid, mxid)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a bug introduced in v2.4.0 that caused association unbindings to fail with an Internal Server Error.