Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eslint-plugin-matrix-org to enable @typescript-eslint/consistent-type-imports rule #4680

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Bump eslint-plugin-matrix-org to enable @typescript-eslint/consistent-type-imports rule #4680

merged 3 commits into from
Feb 5, 2025
+1,760 −1,571

Conversation

hughns
Copy link
Member

@hughns hughns commented Feb 3, 2025 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@hughns hughns added the T-Task Tasks for the team like planning label Feb 3, 2025
@hughns hughns mentioned this pull request Feb 3, 2025
Closed
4 tasks
@hughns hughns marked this pull request as ready for review February 3, 2025 10:10
@hughns hughns requested review from a team as code owners February 3, 2025 10:10
t3chguy
t3chguy approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was horrendous =(

andybalaam
andybalaam approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeballed to confirm it only touches imports.

@andybalaam andybalaam removed the request for review from richvdh February 3, 2025 11:57
toger5
toger5 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hughns hughns added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit ff1db2b Feb 5, 2025
30 checks passed
@hughns hughns deleted the hughns/update-eslint-plugin-matrix-org branch February 5, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toger5 toger5 toger5 approved these changes

@t3chguy t3chguy t3chguy approved these changes

@andybalaam andybalaam andybalaam approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-team

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hughns @andybalaam @t3chguy @toger5