Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update missing references for numpydoc 1.8.0 #28718

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 13, 2024

PR summary

The numpydoc 1.8.0 release re-ordered some sections [1] in generated docs, which caused our missing reference extension to no longer ignore some entries since they are at different lines.

Fixes #28715

[1] numpy/numpydoc#571

PR checklist

The numpydoc 1.8.0 release re-ordered some sections [1] in generated
docs, which caused our missing reference extension to no longer ignore
some entries since they are at different lines.

Fixes matplotlib#28715

[1] numpy/numpydoc#571
@github-actions github-actions bot removed the Documentation: build building the docs label Aug 13, 2024
@QuLogic
Copy link
Member Author

QuLogic commented Aug 13, 2024

As a side note, this doesn't fail on the v3.9.x branch. Probably this has something to do with cda4372 but I didn't look into why exactly.

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming failing tests are unrelated?

@QuLogic
Copy link
Member Author

QuLogic commented Aug 14, 2024

That's a change in pybind11, which is unfortunately my fault: pybind/pybind11#5300 (comment)

@timhoffm timhoffm merged commit 315da10 into matplotlib:main Aug 14, 2024
35 of 39 checks passed
@QuLogic QuLogic deleted the npd180 branch August 14, 2024 09:15
@QuLogic QuLogic added this to the v3.10.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CI doc builds fail since a couple of days
3 participants