Skip to content

Commit a84bdb9

Browse files
authored
Merge pull request #510 from mathuo/479-is-there-any-way-to-focus-the-panel-content
feat: fix rendering
2 parents 7b0cc49 + 9523e6f commit a84bdb9

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

packages/dockview-core/src/dockview/dockviewComponent.ts

+12-12
Original file line numberDiff line numberDiff line change
@@ -272,16 +272,25 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
272272
readonly activePanel: IDockviewPanel | undefined;
273273
readonly totalPanels: number;
274274
readonly panels: IDockviewPanel[];
275+
readonly orientation: Orientation;
275276
readonly onDidDrop: Event<DockviewDidDropEvent>;
276277
readonly onWillDrop: Event<DockviewWillDropEvent>;
277278
readonly onWillShowOverlay: Event<WillShowOverlayLocationEvent>;
278-
readonly orientation: Orientation;
279+
readonly onDidRemovePanel: Event<IDockviewPanel>;
280+
readonly onDidAddPanel: Event<IDockviewPanel>;
281+
readonly onDidLayoutFromJSON: Event<void>;
282+
readonly onDidActivePanelChange: Event<IDockviewPanel | undefined>;
283+
readonly onWillDragPanel: Event<TabDragEvent>;
284+
readonly onWillDragGroup: Event<GroupDragEvent>;
285+
readonly onDidRemoveGroup: Event<DockviewGroupPanel>;
286+
readonly onDidAddGroup: Event<DockviewGroupPanel>;
287+
readonly onDidActiveGroupChange: Event<DockviewGroupPanel | undefined>;
288+
readonly options: DockviewComponentOptions;
279289
updateOptions(options: DockviewComponentUpdateOptions): void;
280290
moveGroupOrPanel(options: MoveGroupOrPanelOptions): void;
281291
moveGroup(options: MoveGroupOptions): void;
282292
doSetGroupActive: (group: DockviewGroupPanel, skipFocus?: boolean) => void;
283293
removeGroup: (group: DockviewGroupPanel) => void;
284-
options: DockviewComponentOptions;
285294
addPanel<T extends object = Parameters>(
286295
options: AddPanelOptions<T>
287296
): IDockviewPanel;
@@ -299,12 +308,6 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
299308
toJSON(): SerializedDockview;
300309
fromJSON(data: SerializedDockview): void;
301310
//
302-
readonly onDidRemovePanel: Event<IDockviewPanel>;
303-
readonly onDidAddPanel: Event<IDockviewPanel>;
304-
readonly onDidLayoutFromJSON: Event<void>;
305-
readonly onDidActivePanelChange: Event<IDockviewPanel | undefined>;
306-
readonly onWillDragPanel: Event<TabDragEvent>;
307-
readonly onWillDragGroup: Event<GroupDragEvent>;
308311
addFloatingGroup(
309312
item: IDockviewPanel | DockviewGroupPanel,
310313
coord?: { x: number; y: number }
@@ -318,9 +321,6 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
318321
onWillClose?: (event: { id: string; window: Window }) => void;
319322
}
320323
): Promise<void>;
321-
readonly onDidRemoveGroup: Event<DockviewGroupPanel>;
322-
readonly onDidAddGroup: Event<DockviewGroupPanel>;
323-
readonly onDidActiveGroupChange: Event<DockviewGroupPanel | undefined>;
324324
}
325325

326326
export class DockviewComponent
@@ -1845,7 +1845,7 @@ export class DockviewComponent
18451845
const removedPanel: IDockviewPanel | undefined = this.movingLock(
18461846
() =>
18471847
sourceGroup.model.removePanel(sourceItemId, {
1848-
skipSetActive: true,
1848+
skipSetActive: false,
18491849
skipSetActiveGroup: true,
18501850
})
18511851
);

0 commit comments

Comments
 (0)